[umbrello] [Bug 73847] support for UML tagged values

Oliver Kellogg bugzilla_noreply at kde.org
Mon Dec 21 23:37:42 GMT 2020


https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #33 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit a7fd4318f7397cbe77f3ae4697f5e482ba31eded by Oliver Kellogg.
Committed on 30/10/2020 at 20:56.
Pushed by okellogg into branch 'master'.

Hook up UMLObject::m_TaggedValues in widgets and class options:

umbrello/basictypes.h
- Add namespace ShowStereoType with Enum { None, Name, Tags }.

umbrello/umbrello.kcfg
- In group "Class Options" change entry "showStereoType" to type "Enum"
  with choices "None", "Name", "Tags".

umbrello/optionstate.h
- In class ClassState change type of member showStereoType to
  Uml::ShowStereoType::Enum.

umbrello/optionstate.cpp
- Adjust function ClassState::loadFromXMI1 to changed type of member
  showStereoType.

umbrello/umlwidgets/umlwidget.{h,cpp}
- Change type of member m_showStereotype to Uml::ShowStereoType::Enum.
- At function showStereotype change return type to
  Uml::ShowStereoType::Enum.
- At function setShowStereotype change argument type to
  Uml::ShowStereoType::Enum.
- New function tags() returns stringified m_umlObject->tags().

umbrello/umlwidgets/widgetbase.cpp
- In function slotMenuSelection add deprecation note at case
  ListPopupMenu::mt_{Show,Hide}_Stereotypes_Selection.

umbrello/umlwidgets/classifierwidget.h
- At enum VisualProperty add deprecation note on value ShowStereotype.

umbrello/umlwidgets/classifierwidget.cpp
- Adjust to change in type of OptionState::ClassState::showStereoType
  and UMLWidget::m_showStereotype.  Affect methods:
  - ClassifierWidget(UMLScene *, UMLClassifier *)
  - ClassifierWidget(UMLScene *, UMLPackage *)
  - bool visualProperty(VisualProperty) const
  - void setVisualPropertyCmd(VisualProperty, bool)
  - QSizeF calculateSize(bool withExtensions) const
  - void paint(QPainter *, const QStyleOptionGraphicsItem *, QWidget *)
  - void changeToClass()
  - void changeToInterface()
  - void changeToPackage()
  - bool loadFromXMI1(QDomElement &)
  - void saveToXMI1(QDomDocument &, QDomElement &)

umbrello/umlwidgets/entitywidget.cpp
- In function slotMenuSelection remove case
  ListPopupMenu::mt_Show_Stereotypes, it is handled in
  UMLWidget::slotMenuSelection().

umbrello/menus/widgetbasepopupmenu.cpp
- Adjust function makeClassifierShowPopup to changed return type of
  UMLWidget::showStereotype().

umbrello/dialogs/pages/classoptionspage.{h,cpp}
- Change type of member m_showStereotypeCB to KComboBox*.
  Reason: It shall represent the values of Uml::ShowStereoType::Enum.
- New function createShowStereotypeCB(QGroupBox*) encapsulates creation
  of the KComboBox for m_showStereotype.
  For the moment this is a member method but it could be made "static"
  or be moved to Dialog_Utils.

M  +14   -2    umbrello/basictypes.h
M  +23   -10   umbrello/dialogs/pages/classoptionspage.cpp
M  +3    -1    umbrello/dialogs/pages/classoptionspage.h
M  +1    -1    umbrello/menus/widgetbasepopupmenu.cpp
M  +1    -1    umbrello/optionstate.cpp
M  +2    -2    umbrello/optionstate.h
M  +7    -2    umbrello/umbrello.kcfg
M  +57   -21   umbrello/umlwidgets/classifierwidget.cpp
M  +5    -1    umbrello/umlwidgets/classifierwidget.h
M  +2    -1    umbrello/umlwidgets/entitywidget.cpp
M  +47   -5    umbrello/umlwidgets/umlwidget.cpp
M  +4    -3    umbrello/umlwidgets/umlwidget.h
M  +2    -0    umbrello/umlwidgets/widgetbase.cpp

https://invent.kde.org/sdk/umbrello/commit/a7fd4318f7397cbe77f3ae4697f5e482ba31eded

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list