D23635: Fix build with cmake < 3.7
Wolfgang Bauer
noreply at phabricator.kde.org
Sun Sep 1 12:27:11 BST 2019
wbauer created this revision.
wbauer added a project: Umbrello.
Herald added a subscriber: umbrello-devel.
wbauer requested review of this revision.
REVISION SUMMARY
`GREATER_EQUAL` was introduced in cmake 3.7, but the specified minimum version is 2.8.11.
So use `NOT LESS` instead to still support older cmake versions too.
TEST PLAN
Builds fine with cmake 3.5.2 now, and also newer versions (haven't tried older versions).
Before, I got this error when building umbrello master or 19.08.0 with cmake 3.5.2:
CMake Error at CMakeLists.txt:12 (if):
if given arguments:
"KDE_APPLICATIONS_VERSION_MICRO" "GREATER_EQUAL" "70"
Unknown arguments specified
REPOSITORY
R139 Umbrello
REVISION DETAIL
https://phabricator.kde.org/D23635
AFFECTED FILES
CMakeLists.txt
To: wbauer
Cc: umbrello-devel, vanderbilt, astranieri
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20190901/b62029d3/attachment.html>
More information about the umbrello-devel
mailing list