[umbrello] [Bug 53369] composite (nested) states in state diagrams

[Carsten Behling]

https://bugs.kde.org/show_bug.cgi?id=53369

--- Comment #30 from Carsten Behling <carsten.behling at gmail.com> ---
(In reply to Carsten Behling from comment #29)
> (In reply to Ralf Habacker from comment #28)
> > Git commit 2148d2c766430714b3701247133a2166f75049b6 by Ralf Habacker.
> > Committed on 01/11/2019 at 08:56.
> > Pushed by habacker into branch 'master'.
> > 
> > Add support for non resizable widgets and apply to combined state widgets
> > 
> > M  +6    -3    umbrello/umlwidgets/statewidget.cpp
> > M  +8    -0    umbrello/umlwidgets/umlwidget.h
> > 
> > https://commits.kde.org/umbrello/2148d2c766430714b3701247133a2166f75049b6
> 
> Hi Ralf, thanks for the outstanding work!!!
> 
> I tested the current version and found two issues:
> 
> 1. When I remove a combined state the state diagram related diagram
> remains.That may be desired behaviour since a class also remains in the Tree
> View if deleted from diagram. However I can't treat a combined state diagram
> in the same way as a class since it can't be dragged and dropped into an
> another state diagram resulting in a combined state element.
> 
> So there are basically two solutions:
> 
> - to allow a drag and drop of a state diagram  into another one appearing as
> a combined state (I think this would be the preferred method)
> - remove the related state diagram with the related combined state
> 
> 2. when I
> a. add a combined state
> b. adding elements e.g. states in the related state Diagramm
> c. keep the element e.g. state selected in the toolbox instead of selecting
> the cursor
> d. switching back to the state diagram with the related combined state
> e. selecting the cursor in the toolbox
> 
> => every time I click into the combined state a new element of the last
> toolbox selection of the sub state chart is added (e.g. a state in this case)
> 
> Im not shure if you are planning to edit directly the combined state. In
> this case the toolbox selection of the parent diagram should be used instead
> of the toolbox from the state diagram of the combined state (that is not
> open/active tab).

Regarding issue 1. in combination with issue 2. the following solution comes
additionally to my mind:

- yes, we keep editing combined states directly and fix the toolbox usage
- State diagrams of substates are always 'hidden' diagrams to distinguish
having only 'Root State Diagrams' visible as diagrams
- states and combined stats will appear instead with the there widgets in the
tree view beyond the top level diagram / beyond there top level combined states

With this solution we won't break the user operating scheme. 
- Combined

-- 
You are receiving this mail because:
You are the assignee for the bug.