[umbrello] [Bug 390509] Not possible to select notes under a fragment widget in sequence diagrams

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=390509

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |2.24.3 (KDE Applications
                   |                            |17.12.3)
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/umb
                   |                            |rello/45d667bbbf1989a511a5e
                   |                            |99621e250007ed99270

--- Comment #1 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 45d667bbbf1989a511a5e99621e250007ed99270 by Ralf Habacker.
Committed on 16/02/2018 at 09:49.
Pushed by habacker into branch 'Applications/17.12'.

Fix 'Not possible to select notes under a fragment widget in sequence diagrams'

- remove suspicious code handing of setting z value in UMLWidget::setSelected()
  which should be always handled in toForeground()
- disable foreground handling for CombinedFragmentWidget and BoxWidget
  by making toForeground() virtual and adding related overrides.
- set z value for CombinedFragmentWidget to the same level as BoxWidget

There is a remaining issue that a box widget cannot be selected if the
box widget is completly inside a combined fragment widget and created
before the combined fragment widget.
FIXED-IN:2.24.3 (KDE Applications 17.12.3)

M  +4    -0    umbrello/umlwidgets/boxwidget.cpp
M  +3    -0    umbrello/umlwidgets/boxwidget.h
M  +5    -0    umbrello/umlwidgets/combinedfragmentwidget.cpp
M  +1    -0    umbrello/umlwidgets/combinedfragmentwidget.h
M  +0    -8    umbrello/umlwidgets/umlwidget.cpp
M  +2    -1    umbrello/umlwidgets/umlwidget.h

https://commits.kde.org/umbrello/45d667bbbf1989a511a5e99621e250007ed99270

-- 
You are receiving this mail because:
You are the assignee for the bug.