New Defects reported by Coverity Scan for rhabacker/umbrello

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.

3 new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.
35 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 171403:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/umlmodel/umlattributelist.h: 26 in ()


________________________________________________________________________________________________________
*** CID 171403:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/umlmodel/umlattributelist.h: 26 in ()
20     typedef QListIterator<UMLAttribute*> UMLAttributeListIt;
21     
22     /**
23      * This sub-class adds copyInto and clone to the QPtrList<UMLAttribute>
24      * base class.
25      */
>>>     CID 171403:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "UMLAttributeList" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
26     class UMLAttributeList : public QList<UMLAttribute*>
27     {
28     public:
29     
30         UMLAttributeList();
31     

** CID 171400:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/umlmodel/umlclassifierlistitemlist.h: 26 in ()


________________________________________________________________________________________________________
*** CID 171400:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/umlmodel/umlclassifierlistitemlist.h: 26 in ()
20     typedef QListIterator<UMLClassifierListItem*> UMLClassifierListItemListIt;
21     
22     /**
23      * This sub-class adds copyInto and clone to the QPtrList<UMLClassifierListItem>
24      * base class.
25      */
>>>     CID 171400:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "UMLClassifierListItemList" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
26     class UMLClassifierListItemList : public QList<UMLClassifierListItem*>
27     {
28     public:
29     
30         UMLClassifierListItemList();
31         UMLClassifierListItemList(const UMLClassifierListItemList& other);

** CID 171399:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/petalnode.h: 48 in ()


________________________________________________________________________________________________________
*** CID 171399:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/coverity/src/umbrello/umbrello/petalnode.h: 48 in ()
42         /**
43          * Use `string' if it is not empty.
44          * Use `node' if it is not NULL.
45          * Either `string' is set, or `node', but never both.
46          * (Perhaps this should be a union but that is ugly.)
47          */
>>>     CID 171399:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "PetalNode::StringOrNode" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
48         struct StringOrNode {
49             QString string;
50             PetalNode *node;
51             StringOrNode() { node = 0; }
52             virtual ~StringOrNode() { }
53             bool isEmpty() { return (string.isEmpty() && node == 0); }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbneWfoX0F52Gghq-2BqUUFh5eVd8TaO133jUuHRtUP-2FQWy-2BSqTKvXGWB4PJ4toJHP0A-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR9C-2FKUadMiBhkOn4PYiqqS6WqyOV-2FV4KWE7HoVkfSh9zKeJEVdNpqIjWLu0wdw8ot-2F1xhAjqysJ47nYDFkUgCi31vhH7LOy8ItymuiT4MmQCR0w3UVUgHkKf0PrMdA8bAgr-2FOQpjR2M13J8hid6i7a5rV9eVvNLyyMHngwyS8UcHfy-2FLr2PwrIZIKtyO2-2F0mlg-3D

To manage Coverity Scan email notifications for "umbrello-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4SjuUo8WwZlhalaw77wxDR6TvlGtHG9IoMCHNAtdPIo0gfvkxSgjiMukzLDgKgS6BzgYg-2Fe-2FHA96GDtTS-2FfrSaW7e-2BE4SCnFcHBrZn05zc8E-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR9C-2FKUadMiBhkOn4PYiqqS6xX0y6EvO-2BW9L6sUwQz7WLTQ3xX1iayAvJwZVdQmEkbuEVIqSMrkGE4qs-2BaMozfgtfbPZjbYMScW6WoZawVI-2FWhcOwNtxI2JxL3Gmp1s6p5FAONVBY3nlBQY-2F6OnN5Fsjj3uzxTFn3GKpM14NxNXVRHzLmVnsgTSJX8yvlwX3a78-3D