New Defects reported by Coverity Scan for rhabacker/umbrello

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.

4 new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 169655:    (USE_AFTER_FREE)
/home/coverity/src/umbrello/umbrello/umldoc.cpp: 1930 in UMLDoc::removeUMLObject(UMLObject *, bool)()
/home/coverity/src/umbrello/umbrello/umldoc.cpp: 1930 in UMLDoc::removeUMLObject(UMLObject *, bool)()


________________________________________________________________________________________________________
*** CID 169655:    (USE_AFTER_FREE)
/home/coverity/src/umbrello/umbrello/umldoc.cpp: 1930 in UMLDoc::removeUMLObject(UMLObject *, bool)()
1924                     if (deleteObject)
1925                         delete umlobject;
1926                 } else {
1927                     uError() << umlobject->name() << ": parent package is not set !";
1928                 }
1929             }
>>>     CID 169655:    (USE_AFTER_FREE)
>>>     Passing freed pointer "umlobject" as an argument to "sigObjectRemoved".
1930             emit sigObjectRemoved(umlobject);
1931         }
1932         setModified(true);
1933     }
1934     
1935     /**
/home/coverity/src/umbrello/umbrello/umldoc.cpp: 1930 in UMLDoc::removeUMLObject(UMLObject *, bool)()
1924                     if (deleteObject)
1925                         delete umlobject;
1926                 } else {
1927                     uError() << umlobject->name() << ": parent package is not set !";
1928                 }
1929             }
>>>     CID 169655:    (USE_AFTER_FREE)
>>>     Passing freed pointer "umlobject" as an argument to "sigObjectRemoved".
1930             emit sigObjectRemoved(umlobject);
1931         }
1932         setModified(true);
1933     }
1934     
1935     /**

** CID 169653:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umllistview.cpp: 2158 in UMLListView::slotCollapsed(QTreeWidgetItem *)()


________________________________________________________________________________________________________
*** CID 169653:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umllistview.cpp: 2158 in UMLListView::slotCollapsed(QTreeWidgetItem *)()
2152     
2153     /**
2154      * Calls updateFolder() on the item to update the icon to closed.
2155      */
2156     void UMLListView::slotCollapsed(QTreeWidgetItem * item)
2157     {
>>>     CID 169653:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "myItem" = "dynamic_cast <UMLListViewItem *>(item)".
2158         UMLListViewItem * myItem = dynamic_cast<UMLListViewItem*>(item);
2159         if (isExpandable(myItem->type())) {
2160             myItem->updateFolder();
2161         }
2162     }
2163     

** CID 169652:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umllistview.cpp: 2147 in UMLListView::slotExpanded(QTreeWidgetItem *)()


________________________________________________________________________________________________________
*** CID 169652:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umllistview.cpp: 2147 in UMLListView::slotExpanded(QTreeWidgetItem *)()
2141     
2142     /**
2143      * Calls updateFolder() on the item to update the icon to open.
2144      */
2145     void UMLListView::slotExpanded(QTreeWidgetItem * item)
2146     {
>>>     CID 169652:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "myItem" = "dynamic_cast <UMLListViewItem *>(item)".
2147         UMLListViewItem * myItem = dynamic_cast<UMLListViewItem*>(item);
2148         if (isExpandable(myItem->type())) {
2149             myItem->updateFolder();
2150         }
2151     }
2152     

** CID 155784:  Uninitialized members  (UNINIT_CTOR)
/home/coverity/src/umbrello/umbrello/umlappprivate.h: 83 in UMLAppPrivate::UMLAppPrivate(UMLApp *)()


________________________________________________________________________________________________________
*** CID 155784:  Uninitialized members  (UNINIT_CTOR)
/home/coverity/src/umbrello/umbrello/umlappprivate.h: 83 in UMLAppPrivate::UMLAppPrivate(UMLApp *)()
77             editor = KTextEditor::Editor::instance();
78     #else
79             editor = KTextEditor::EditorChooser::editor();
80     #endif
81             logWindow = new QListWidget;
82             connect(logWindow, SIGNAL(itemDoubleClicked(QListWidgetItem *)), this, SLOT(slotLogWindowItemDoubleClicked(QListWidgetItem *)));
>>>     CID 155784:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "objectsWindow" is not initialized in this constructor nor in any functions that it calls.
83         }
84     
85         ~UMLAppPrivate()
86         {
87             delete logWindow;
88         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbneWfoX0F52Gghq-2BqUUFh5eVd8TaO133jUuHRtUP-2FQWy-2BSqTKvXGWB4PJ4toJHP0A-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR-2FsMtpdWR47KaFm63ePE3hF9uDon2giNBXi-2B7Wjcw-2FqRIKfIV0PsMapN3nPMIGqn4Wy4aF5NHJVdzbIigIlcE4tkEDNAJQxcQ8Ow9lmeHLpMvJgJJRQVV4mu5EF2zMhhuMC2f5a5Zmp-2FFXr4EM47rQLNdqXq0gPNqKfsBq9cyWen3vO00H2PF3KPrVqH0-2BoKI0-3D

To manage Coverity Scan email notifications for "umbrello-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4SjuUo8WwZlhalaw77wxDR6TvlGtHG9IoMCHNAtdPIo0gfvkxSgjiMukzLDgKgS6BzgYg-2Fe-2FHA96GDtTS-2FfrSaW7e-2BE4SCnFcHBrZn05zc8E-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR-2FsMtpdWR47KaFm63ePE3hFPyO5aijl-2BGW3OOtCMLUDEw3uao-2FidglV3we9f0VvwXcjXUen8ynzaNNyOlg6FvaH0RJ7k1-2FYIpGLEAPt8zEXtahCnTBAZAFGNByQpaqepxpyUB-2FUYsMDfNQKRIvVVdoa3vGdOW8Rytyp-2BMUIt3ElfUk9MnhDaQt8h57nTxtCLe0-3D