[umbrello] [Bug 368282] Make type casting more robust

Ralf Habacker via KDE Bugzilla bugzilla_noreply at kde.org
Tue Sep 6 17:12:44 UTC 2016


https://bugs.kde.org/show_bug.cgi?id=368282

--- Comment #6 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 8c6bad8a76df59a11bf67ce62e76c3bda0f12007 by Ralf Habacker.
Committed on 06/09/2016 at 17:08.
Pushed by habacker into branch 'master'.

Fix warning about missing brackets and logic.

M  +2    -2    umbrello/umlmodel/umlobject.cpp

http://commits.kde.org/umbrello/8c6bad8a76df59a11bf67ce62e76c3bda0f12007

--- Comment #5 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 6d5686f264ddfda0e6bf030e16902569e7dc02df by Ralf Habacker.
Committed on 06/09/2016 at 16:59.
Pushed by habacker into branch 'master'.

Fix crash in TEST_UMLObject::test_fullyQualifiedName() caused by creating uml
model related objects on stack.

Because QCOMPARE() returns the function immediatly on error we need to
delete related objects on ourself on exit. This is performed by adding
objects to delete with cleanupOnExit().

M  +15   -12   unittests/TEST_umlobject.cpp
M  +8    -0    unittests/testbase.cpp
M  +4    -0    unittests/testbase.h

http://commits.kde.org/umbrello/6d5686f264ddfda0e6bf030e16902569e7dc02df

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list