My GSoC Project

[Lays Rodrigues]

Hi Everyone!
I finally did the rebase of branch frameworks against master and fixed all
the conflicts.
Now it's everything on the remote branch. I don't know if umbrello is
stable after this rebase, how we can have sure that everything is ok? I
runned all the unit tests and everything works fine.
I didn't add to commits the FIXED flag about the bugs that I fixed. But I
think that a rebase to edit the commits can work for it. However, I think
that only after the final review of the new widgets and tests, the bugs can
be closed. I remember that have small bugs on the new widgets for
attributes, but at the time I didnt take notes.
The remote branch frameworks-gsoc can be deleted.
I hope to hear from you(Ralf) soon.
Regards,

On Mon, Oct 24, 2016 at 10:56 PM, Lays Rodrigues <
laysrodriguessilva at gmail.com> wrote:

> Hi everyone!
> I started to rebase frameworks against master, already solved all
> conflicts, but a lot of files is broken. I hope that until the end of the
> week I can fix all of this.
> Soon I'm going to push the fixes to frameworks, and ask again for the
> review.
> I got some awkward stuff between master and frameworks during rebase, so I
> solve the conflicts in the best way that I could imagine, don't know if is
> the best, but was the best that I could do.
> Cheers,
>
>
>
> On Wed, Sep 28, 2016 at 8:55 AM, Ralf Habacker <ralf.habacker at freenet.de>
> wrote:
>
>> Am 28.09.2016 um 09:42 schrieb Ralf Habacker:
>>
>> Am 27.09.2016 um 17:12 schrieb Ralf Habacker:
>>
>> Am 24.09.2016 um 02:46 schrieb Lays Rodrigues:
>>
>>
>> So I think that depends a little on you reviewing my work and
>> highlighting points that I need to check.
>>
>> I'm going to try to merge git master into frameworks, which will give a
>> detailed list of issues.
>>
>> I took a look at the type Qualifier and Modifier widgets:
>> 1.1 They are only visible in class attributes dialog, not in other
>> dialogs providing types like operations, template, datatype and entity
>> attribute (if related)
>> 1.2 Opening the attribute dialog on an attribute type for example  'const
>> int *' does not select 'const' in the qualifier widget and not '*' in the
>> modifier widget, the complete type including qualifier and modifier is
>> displayed in the 'type' field.
>> 1.3 The new widgets are visible for all languages, but only applied for
>> cpp language.
>> 1.4 Because the xmi file format has been changed the related version
>> needs to be incremented in version.h
>> 1.5 The new xmi file attribute needs to be documentated in the xmi file
>> dtd.
>>
>> BTW: While reviewing it turned out that umbrello has a bug in this area
>> https://bugs.kde.org/show_bug.cgi?id=369464
>>
>> Ralf
>>
>>
>>
>
>
> --
> *Lays Rodrigues*
> *Software Developer at KDE*
> *Computer Science Student at Federal Fluminense University*
> *laysrodriguesdev.wordpress.com <http://laysrodriguesdev.wordpress.com>*
> *Telegram: @lays147*
> *IRC: lays147*
> *Phone: +55 22 999899467 <%2B55%2022%20999899467>*
>



-- 
*Lays Rodrigues*
*Software Developer at KDE*
*Computer Science Student at Federal Fluminense University*
*laysrodriguesdev.wordpress.com <http://laysrodriguesdev.wordpress.com>*
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 999899467*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20161027/26cffd7e/attachment-0001.html>