[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

Ralf Habacker bugzilla_noreply at kde.org
Fri Nov 18 23:47:09 UTC 2016


https://bugs.kde.org/show_bug.cgi?id=371990

--- Comment #17 from Ralf Habacker <ralf.habacker at freenet.de> ---
Comment on attachment 102312
  --> https://bugs.kde.org/attachment.cgi?id=102312
Turn PinPortBase into real child widget.

A quick look shows that the following code 

+        foreach(QGraphicsItem* item, widget->childItems()) {
+            UMLWidget* child = dynamic_cast<UMLWidget*>(item);
+            QDomDocument doc;
+            m_children.append(doc.createElement(QLatin1String("child")));
+            child->saveToXMI(doc, m_children.back());
+        }
+

needs to goto into ComponentWidget::saveToXMI()

and this
+        foreach(QDomElement childElement, m_children) {
+            widgetElement = childElement.firstChild().toElement();
+            widget = umlScene->loadWidgetFromXMI(widgetElement);
+            if (0 != widget) {
+                addWidgetToScene(widget);
+            }
+        }

into ComponentWidget::loadToXMI() to support also saving to and loading from
file. 

If this is fixed I'm going to test this implementation. Thanks for
contribution.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list