[umbrello-devel] [umbrello] [Bug 92994] class and other dialogues update model before pressing OK or apply

[Ralf Habacker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=92994

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ralf.habacker at freenet.de

--- Comment #5 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to Lays Rodrigues from comment #4)
> I guess that this bug is because when you insert a new
> attribute/template/operations, a slot apply inside the
> class(umlattributedialog.cpp) is already called. Isn't a slot addNewFoo, the
> slot apply is called automatically, so that's why the file is automatically
> updated in add or remove this features.
yes. 
Many property items are hold only in the widget and are written back to the
related object on pressing okay or apply. Pressing cancel simply do not write
back the data into the object.

> I think that the best way is remove the button "apply", because we have two
> ways of include new attribute/template/operations, by the dialog of
> properties or using direct access, and since the dialogs of this features
> have his own "Ok" button that already update the file, the button "apply"
> lost his purpose.
But cancel button also looses its purpose. After adding new operations you
cannot undo these adds yet. There may be a way to use the Qt undo framework
(http://doc.qt.io/qt-4.8/qundo.html) on which umbrello undo support is based to
revert changes after pressing cancel.

-- 
You are receiving this mail because:
You are the assignee for the bug.