[umbrello-devel] [umbrello] [Bug 358293] C++ Code Generation Settings don't change anything

[Ralf Habacker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358293

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |ralf.habacker at freenet.de

--- Comment #2 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to ryan.niehaus from comment #1)
> Created attachment 96895 [details]
> A patch to fix part of the issue
> This patch makes it so the generated C++ commenting style selection actually
> works now.
Did a quick review and found a few issues: 
> Settings aren't actually saved
1. works 
> Generated code still uses // comments instead of /* */ when that style is selected.

2. The generated comments in // style for example on classes looks like
  /// 
  /// class SDL_RWops

and for  methods like
  /// 
  /// Set the value of type
  /// @param new_var the new value of type
  void setType (Uint32 new_var)   {

in /* */ mode for classes 

  /** 
   * class SDL_RWops
   */

but for methods 

/*  */
/* Methods */
/*  */

which should be 

/**
  * Methods
 */

There may be more issues, which could be verified by opening the code generator
test case   'test/test-COG.xmi' from the umbrello source and generating code
with it.

2. Please follow topic 12. of CODING-STYLE from the umbrello source eg. 
if (...) {
        ...
} else { 
     .... 
}

3. If possible use 'git format-patch' to generate the patch to have a complete
patch header, which could be easily applied with 'git am'.

-- 
You are receiving this mail because:
You are the assignee for the bug.