New Defects reported by Coverity Scan for rhabacker/umbrello

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.

4 new defect(s) introduced to rhabacker/umbrello found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 173356:  Null pointer dereferences  (NULL_RETURNS)
/home/coverity/src/umbrello/umbrello/cmds/widget/cmdcreatewidget.cpp: 55 in Uml::CmdCreateWidget::redo()()


________________________________________________________________________________________________________
*** CID 173356:  Null pointer dereferences  (NULL_RETURNS)
/home/coverity/src/umbrello/umbrello/cmds/widget/cmdcreatewidget.cpp: 55 in Uml::CmdCreateWidget::redo()()
49         {
50             UMLWidget* umlWidget = scene()->findWidget(m_widgetId);
51             if (umlWidget == 0) {
52                 // If the widget is not found, the add command was undone. Load the
53                 // widget back from the saved XMI state.
54                 QDomElement widgetElement = m_element.firstChild().toElement();
>>>     CID 173356:  Null pointer dereferences  (NULL_RETURNS)
>>>     Assigning: "umlWidget" = null return value from "loadWidgetFromXMI".
55                 umlWidget = scene()->loadWidgetFromXMI(widgetElement);
56     
57                 addWidgetToScene(umlWidget);
58             }
59         }
60     

** CID 173355:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/listpopupmenu.cpp: 422 in ListPopupMenu::insertSingleSelectionMenu(WidgetBase *)()


________________________________________________________________________________________________________
*** CID 173355:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/listpopupmenu.cpp: 422 in ListPopupMenu::insertSingleSelectionMenu(WidgetBase *)()
416              insert(mt_Rename);
417              insert(mt_Change_Font);
418              break;
419            }
420         case WidgetBase::wt_Class:
421         case WidgetBase::wt_Interface:
>>>     CID 173355:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dynamic cast to pointer "dynamic_cast <ClassifierWidget *>(object)" can return "NULL".
422             makeClassifierPopup(dynamic_cast<ClassifierWidget*>(object));
423             break;
424     
425         case WidgetBase::wt_Enum:
426             insertSubMenuNew(mt_Enum);
427             insertSubMenuColor(object->useFillColor());

** CID 173354:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/cmds/widget/cmdremovewidget.cpp: 35 in Uml::CmdRemoveWidget::CmdRemoveWidget(UMLWidget *)()


________________________________________________________________________________________________________
*** CID 173354:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/cmds/widget/cmdremovewidget.cpp: 35 in Uml::CmdRemoveWidget::CmdRemoveWidget(UMLWidget *)()
29             setText(i18n("Remove widget : %1", widget->name()));
30     
31             foreach(QGraphicsItem* item, widget->childItems()) {
32                 UMLWidget* child = dynamic_cast<UMLWidget*>(item);
33                 QDomDocument doc;
34                 m_children.append(doc.createElement(QLatin1String("child")));
>>>     CID 173354:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "child" to "saveToXMI", which dereferences it. (The dereference happens because this is a virtual function call.)
35                 child->saveToXMI(doc, m_children.back());
36             }
37     
38             QDomDocument doc;
39             m_element = doc.createElement(QLatin1String("widget"));
40             widget->saveToXMI(doc, m_element);

** CID 173353:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umlscene.cpp: 1194 in UMLScene::removeOwnedWidgets(UMLWidget *)()


________________________________________________________________________________________________________
*** CID 173353:  Null pointer dereferences  (FORWARD_NULL)
/home/coverity/src/umbrello/umbrello/umlscene.cpp: 1194 in UMLScene::removeOwnedWidgets(UMLWidget *)()
1188      *
1189      * @param o The owner widget that will be removed.
1190      */
1191     void UMLScene::removeOwnedWidgets(UMLWidget* o)
1192     {
1193         foreach(QGraphicsItem* item, o->childItems()) {
>>>     CID 173353:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "widget" = "dynamic_cast <UMLWidget *>(item)".
1194             UMLWidget* widget = dynamic_cast<UMLWidget*>(item);
1195             if (widget->isPinWidget() ||
1196                 widget->isPortWidget()) {
1197                 removeWidgetCmd(widget);
1198             }
1199         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbneWfoX0F52Gghq-2BqUUFh5eVd8TaO133jUuHRtUP-2FQWy-2BSqTKvXGWB4PJ4toJHP0A-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR-2FXwEzFtpNgcKddd1ifhysyv1Pu4AIy4UBj9WcF3-2B7fHhv-2F66ctHaWZDkUd08q3bbcQN-2FoSLwSsZAv9eAw9g8uvvDcglqy64MUc2zhvve8gzVj0pNjVsy776ZT0kAHLXnyVtKMA-2Bg-2BxTrn0p7LlIJ2dRPVfJjFTH9FMt-2BNIlizjIH2gfYX-2FSe-2FQKr28DLAJosk-3D

To manage Coverity Scan email notifications for "umbrello-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4SjuUo8WwZlhalaw77wxDR6TvlGtHG9IoMCHNAtdPIo0gfvkxSgjiMukzLDgKgS6BzgYg-2Fe-2FHA96GDtTS-2FfrSaW7e-2BE4SCnFcHBrZn05zc8E-3D_EShgirRohr6FUhdhEf2AbZ1nkp0TrbQOboOeetrIkR-2FXwEzFtpNgcKddd1ifhysyM14cpLWHywoVK9abuvZmYfwBMQ82Et3RmRiNLMACvXvtxuPI5sw92SHb5hhZr6qDes1m34vDxAc9wyYnYLQDsCy-2BNivtD8qzlW3Sz9S2yqb5zWEeW7bTbuQ0kfQQOJgcGpkUyQ1C3BK5zsU-2Fs7HQJP8ZXMLBTw-2B-2FqOvwNsKwXgw-3D