[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=371990

--- Comment #31 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to clushkou from comment #20)
> I tried to fulfill your request in comment #17, but do not understand how to
> achieve this.
I applied your first approach to git master. Thanks for that contribution.

>  If I simply move the calls to ComponentWidget, I get a crash
> on undo because restoring of child element does not work.

It looks that this would require more refactoring :-( See also my comment
below.

> In addition, if the code needs to be added to ComponentWidget, the same
> adaption is needed in all widgets that allow child Pins / Ports.

>From a internet research I got the impression that ports are used used with
Components (https://en.wikipedia.org/wiki/Component_diagram) and pins with
activities (https://de.wikipedia.org/wiki/Aktion_(UML)).

The load/save implementation differs also between pins and ports in that way:
activities and pins are not backed up by a related uml model objects, they are
only widgets. The relation from the pin widget to the activity widget is
handled with the <pinwidget> tag attribute "widgetaid". The same is true for
the relation port widget to component widget.

Currently I do not have any idea how the refactoring could be done. With that
we have two choices:
1. leave this bug open as reminder for that open task or
2. close this bug because the initial crash has been fixed and a basic
refactoring has been implemented and to open a new bug describing the left
issue as a reminder.

-- 
You are receiving this mail because:
You are the assignee for the bug.