[umbrello-devel] [umbrello] [Bug 340646] Fix issues reported by Coverity scan

Ralf Habacker ralf.habacker at freenet.de
Sat Aug 8 14:09:38 UTC 2015


https://bugs.kde.org/show_bug.cgi?id=340646

--- Comment #82 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 335a582b4878ecb88ba2c97d8f76546ea5822593 by Ralf Habacker, on behalf
of Patrick Eigensatz.
Committed on 08/08/2015 at 14:05.
Pushed by habacker into branch 'Applications/15.08'.

Coverity Check: codegenerators: Fixing unchecked dynamic_casts

This fixes Coverity check CIDs: 71404, 71405, 71409, 71415, 71430,
71432, 71434, 71435, 71438, 71439, 71446, 71453, 71456, 71457,
71458, 71460

Coverity reported lots of errors (> 50) of the same type:

T *var = dynamic_cast<T>(a);
foo(var);

var was never checked against NULL.
REVIEW:124658

M  +17   -0    umbrello/codegenerators/cpp/cppheadercodeaccessormethod.cpp
M  +8    -1   
umbrello/codegenerators/cpp/cppheadercodeclassfielddeclarationblock.cpp
M  +33   -0    umbrello/codegenerators/cpp/cppsourcecodeaccessormethod.cpp
M  +8    -0   
umbrello/codegenerators/cpp/cppsourcecodeclassfielddeclarationblock.cpp
M  +8    -0    umbrello/codegenerators/d/dcodeaccessormethod.cpp
M  +17   -1    umbrello/codegenerators/d/dcodeclassfielddeclarationblock.cpp
M  +15   -0   
umbrello/codegenerators/java/javacodeclassfielddeclarationblock.cpp
M  +9    -0    umbrello/codegenerators/java/javacodeoperation.cpp
M  +15   -0    umbrello/codegenerators/ruby/rubycodeaccessormethod.cpp
M  +9    -0    umbrello/codegenerators/ruby/rubycodeoperation.cpp

http://commits.kde.org/umbrello/335a582b4878ecb88ba2c97d8f76546ea5822593

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list