[umbrello-devel] [umbrello] [Bug 340646] Fix issues reported by Coverity scan

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=340646

--- Comment #73 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit f296ff14d9b2582fc63aad7356a13e0845900f0c by Ralf Habacker.
Committed on 06/08/2015 at 10:29.
Pushed by habacker into branch 'Applications/15.08'.

Coverity check CID 71398, 71403, 71416, 71450, 71471: Use pass-by-reference
instead of pass-by-value to speed codegeneration up and use less resources.

The flaw/correction is everywhere the same:
... getCodeViewerDialog(... , Settings::CodeViewerState & state)

REVIEW:124358

M  +1    -1    umbrello/codegenerators/codegenerator.cpp
M  +1    -1    umbrello/codegenerators/codegenerator.h
M  +1    -1    umbrello/codegenerators/cpp/cppcodegenerator.cpp
M  +1    -1    umbrello/codegenerators/cpp/cppcodegenerator.h
M  +1    -1    umbrello/codegenerators/d/dcodegenerator.cpp
M  +1    -1    umbrello/codegenerators/d/dcodegenerator.h
M  +1    -1    umbrello/codegenerators/java/javacodegenerator.cpp
M  +1    -1    umbrello/codegenerators/java/javacodegenerator.h
M  +1    -1    umbrello/codegenerators/ruby/rubycodegenerator.cpp
M  +1    -1    umbrello/codegenerators/ruby/rubycodegenerator.h

http://commits.kde.org/umbrello/f296ff14d9b2582fc63aad7356a13e0845900f0c

-- 
You are receiving this mail because:
You are the assignee for the bug.