[umbrello-devel] [umbrello] [Bug 338983] Umbrello crashed when opening entity relationship diagram previously saved

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=338983

--- Comment #6 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 518e457ddfaf94ff023bd0e23202b5189ab9bffb by Oliver Kellogg.
Committed on 10/09/2014 at 21:44.
Pushed by okellogg into branch 'master'.

Premise: The following changes are only after-the-fact crash prevention.
The root question of why the ERD is NULL is unclear.

(In reply to Gabriela Serventi from comment #5)
> [...]
> But, the first ERD is completely unusable. For example, if I press right
> mouse button -> Export as Picture on the ERD, Umbrello crash again with this
> backtrace:
> [...]
> Thread 1 (Thread 0xb77387c0 (LWP 2558)):
> [KCrash Handler]
> #6  0x4bc134c4 in QGraphicsView::scene() const () from /lib/libQtGui.so.4
> #7  0x08333d72 in UMLListView::slotMenuSelection(QAction*) ()
> #8  0x08334c10 in UMLListView::contextMenuEvent(QContextMenuEvent*) ()

umbrello/umllistview.cpp function slotMenuSelection()
- In case ListPopupMenu::mt_Export_Image, guard against NULL return value
  from m_doc->findView(), and guard against its umlScene() being NULL.

> [...]
> And If I press right mouse button ->  Duplicate on the ERD, Umbrello crash
> again with this backtrace:
> [...]
> Thread 1 (Thread 0xb76fd7c0 (LWP 3188)):
> [KCrash Handler]
> #6  0x4bc134c4 in QGraphicsView::scene() const () from /lib/libQtGui.so.4
> #7  0x080e99cd in UMLClipboard::copy(bool) ()
> #8  0x08313625 in UMLApp::editCutCopy(bool) ()
> #9  0x08313869 in UMLApp::slotEditCopy() ()
> #10 0x08333b7d in UMLListView::slotMenuSelection(QAction*) ()
> #11 0x08334c10 in UMLListView::contextMenuEvent(QContextMenuEvent*) ()
> #12 0x4b58c337 in QWidget::event(QEvent*) () from /lib/libQtGui.so.4

umbrello/clipboard/umlclipboard.cpp function copy()
- In case fromView==true, guard against UMLApp::app()->currentView() being
  NULL, and also guard against its umlScene() being NULL.

M  +11   -2    umbrello/clipboard/umlclipboard.cpp
M  +14   -1    umbrello/umllistview.cpp

http://commits.kde.org/umbrello/518e457ddfaf94ff023bd0e23202b5189ab9bffb

-- 
You are receiving this mail because:
You are the assignee for the bug.