[umbrello-devel] [umbrello] [Bug 338797] SEGV crash when umbrello is opening AIXM files

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=338797

--- Comment #8 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to Oliver Kellogg from comment #7)
> (In reply to M Hounsell at ACFR from comment #6)
> > 2014-09-05 00:52:30 Z
> > 
> > Ok, I just did a git pull and a make clean  and it reproduced exactley the
> > same, twice. 
> > Tried again with "Use tabbed diagrams" disabled but same SEGV.
> > 
> 
> Although I cannot reproduce the crash I had a closer look at the backtrace,
> and in fact there is a problem:
> 
> UMLClassifier *ClassifierWidget::classifier() const
> {
>     return static_cast<UMLClassifier*>(m_umlObject);
> }
> 
> Since the recent class-or-package modifications, m_umlObject may also point
> to UMLPackage - which means that the static_cast to UMLClassifier* is
> invalid.

class-or-package uml objects are created of type UMLClassifier. A later retype
to a package only sets the WidgetBase class base type member to UMLPackage, the
object itself is still an UMLClassifier. A cast to UMLClassifier therefore
should not fail. See CppTree2Uml::parseNamespace for more details. 




> I am making the required adjustments and will commit later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.