[umbrello-devel] [umbrello] [Bug 335478] umbrello crash after Java import via wizard

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=335478

--- Comment #6 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 9a16963ece9aeca85a9e678a23ff00f2f59d8730 by Oliver Kellogg.
Committed on 29/05/2014 at 11:05.
Pushed by okellogg into branch 'KDE/4.13'.

(In reply to comment #1)
> it seems, the import does not crash using a single java file using the
> default, i.e. no, package - my original files I wanted to import reside
> inside real packages

It might be that the problem is fixed coincidentally by following change
but without a reproducer there is no way of knowing.

umbrello/codeimport/nativeimportbase.{h,cpp}
- Change member m_parsedFiles to `static'.
  Reason: The files parsed shall be accumulated across all instances of
  NativeImportBase. See e.g. umbrello/codeimport/javaimport.cpp function
  spawnImport() : A new JavaImport importer is created for each file.
  However, m_parsedFiles shall span across all these instances.

umbrello/codeimport/nativeimportbase.cpp
- Additional fix in function preprocess() :
  A Java input line such as
    //***** this is a single line comment *****
  was erroneously treated as a multi line comment opener.
  (Notice the embedded /* which was misinterpreted.)

M  +11   -0    umbrello/codeimport/nativeimportbase.cpp
M  +1    -1    umbrello/codeimport/nativeimportbase.h

http://commits.kde.org/umbrello/9a16963ece9aeca85a9e678a23ff00f2f59d8730

-- 
You are receiving this mail because:
You are the assignee for the bug.