[umbrello-devel] [umbrello] [Bug 225290] Umbrello segmentation fault crash modifying attribute

[Joris Steyn]

https://bugs.kde.org/show_bug.cgi?id=225290

Joris Steyn <jorissteyn at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/umbr |http://commits.kde.org/umbr
                   |ello/61149e5f6a8365ed71a6ed |ello/1e6e3df30e823ed76b176f
                   |a793cb91ada36687b4          |03ae931c2394b10995
      Latest Commit|http://commits.kde.org/umbr |http://commits.kde.org/umbr
                   |ello/1e6e3df30e823ed76b176f |ello/e84b97d0ebc3b0c82a0688
                   |03ae931c2394b10995          |f9daf6365bc22ae405

--- Comment #7 from Joris Steyn <jorissteyn at gmail.com> ---
Git commit 1e6e3df30e823ed76b176f03ae931c2394b10995 by Joris Steyn.
Committed on 01/01/2014 at 21:57.
Pushed by jorissteyn into branch 'KDE/4.11'.

Better fix for attribute creation crash

Previous fix was faulty. The problem occurs when an object is looked up with an
empty name. Instead of not finding an object, umldoc can return an arbitrary
association object instead, resulting in problems in Import_Utils.

This change prevents calling Import_Utils with an empty typeName, so when an
attribute is created without specifying a type, the default behaviour of
creating a new class with Object_Factory is triggered - which handles this case
well.

M  +13   -2    umbrello/dialogs/umlattributedialog.cpp

http://commits.kde.org/umbrello/1e6e3df30e823ed76b176f03ae931c2394b10995

--- Comment #8 from Joris Steyn <jorissteyn at gmail.com> ---
Git commit e84b97d0ebc3b0c82a0688f9daf6365bc22ae405 by Joris Steyn.
Committed on 01/01/2014 at 21:57.
Pushed by jorissteyn into branch 'KDE/4.12'.

Better fix for attribute creation crash

Previous fix was faulty. The problem occurs when an object is looked up with an
empty name. Instead of not finding an object, umldoc can return an arbitrary
association object instead, resulting in problems in Import_Utils.

This change prevents calling Import_Utils with an empty typeName, so when an
attribute is created without specifying a type, the default behaviour of
creating a new class with Object_Factory is triggered - which handles this case
well.

M  +13   -2    umbrello/dialogs/umlattributedialog.cpp

http://commits.kde.org/umbrello/e84b97d0ebc3b0c82a0688f9daf6365bc22ae405

-- 
You are receiving this mail because:
You are the assignee for the bug.