[umbrello-devel] [umbrello] [Bug 340646] Fix issues reported by Coverity scan

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=340646

--- Comment #6 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit ac40f6094ad3b58a28e9637fdb609508a6811af1 by Ralf Habacker.
Committed on 28/11/2014 at 22:26.
Pushed by habacker into branch 'Applications/14.12'.

Coverity check on master at bd16929, CID 71422: Unchecked dynamic_cast
(FORWARD_NULL).

M  +4    -0    umbrello/classifiercodedocument.cpp

http://commits.kde.org/umbrello/ac40f6094ad3b58a28e9637fdb609508a6811af1

--- Comment #5 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 2399b5734b99ee7f7274cfdb17608449243a84f1 by Ralf Habacker.
Committed on 28/11/2014 at 22:23.
Pushed by habacker into branch 'Applications/14.12'.

Coverity check on master at bd16929, CID 71414: Dereference after null check
(FORWARD_NULL).

M  +1    -0    umbrello/classifiercodedocument.cpp

http://commits.kde.org/umbrello/2399b5734b99ee7f7274cfdb17608449243a84f1

--- Comment #4 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit ee1a631fcfedb56aeb11fec1f722230ff0760cea by Ralf Habacker, on behalf
of Oliver Kellogg.
Committed on 30/11/2014 at 19:06.
Pushed by habacker into branch 'Applications/14.12'.

Coverity check on master at 375ea16 CIDs 83526, 83527, 83528, 83529, 83530 :
Logically dead code in file unittests/TEST_basictypes.cpp

- CID 83526: At function test_Corner_toString_fromString() for-loop,
  - use "<=" as comparison operator for staying in loop;
  - replace ++i by i *= 2 on iteration action. Reason: The values of
    the Corner enum are represented as 0x1, 0x2, 0x4, 0x8.

- CID 83527: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83528: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83529: At function test_Region_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83530: At function test_ProgrammingLanguage_toString_fromString()
  for-loop, use "<=" as comparison operator for staying in loop.

M  +5    -5    unittests/TEST_basictypes.cpp

http://commits.kde.org/umbrello/ee1a631fcfedb56aeb11fec1f722230ff0760cea

-- 
You are receiving this mail because:
You are the assignee for the bug.