[umbrello-devel] [umbrello] [Bug 81364] Import Rose model files

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=81364

--- Comment #29 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit a060b1601eade02fe2a33b1d33913e7a23a875c9 by Oliver Kellogg.
Committed on 29/08/2014 at 23:38.
Pushed by okellogg into branch 'master'.

Address http://bugs.kde.org/show_bug.cgi?id=81364#c26,
>
> While working on bug 338536 I notice that the class diagrams in this
> testcase are not loaded, and various related error messages are logged.

Umbrello has a concept of "folders" which are like packages but can
additionally contain diagrams. Rational Rose does not make this distinction;
only packages are used, and packages may contain diagrams.
Umbrello did not support nesting folders inside packages, a case exposed
by this model. Fixed as follows:

umbrello/package.cpp function appendPackages()
- Include objects of type ot_Folder in result list.

umbrello/folder.cpp function findView(id)
- Instead of iterating over m_objects, first recursively gather contained
  packages and folders using UMLPackage::appendPackages() and then iterate
  over the resulting list.
CCMAIL: m.hounsell at acfr.usyd.edu.au

M  +3    -1    umbrello/folder.cpp
M  +3    -3    umbrello/package.cpp

http://commits.kde.org/umbrello/a060b1601eade02fe2a33b1d33913e7a23a875c9

-- 
You are receiving this mail because:
You are the assignee for the bug.