[umbrello-devel] [umbrello] [Bug 191396] Editing attributes in Entity's "Properties" window and adding foreign key constraint causes a crash [invalid UMLObject::getDoc, ClassifierListPage::slotActivateItem, ..., QListWidget::currentItemChanged]

[Andi Fischer]

https://bugs.kde.org/show_bug.cgi?id=191396

Andi Fischer <andi.fischer at hispeed.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/umbr
                   |                            |ello/8eb9a5457ca292712c75ca
                   |                            |5efbc4bf5ff2f88afc

--- Comment #26 from Andi Fischer <andi.fischer at hispeed.ch> ---
Git commit 8eb9a5457ca292712c75ca5efbc4bf5ff2f88afc by Andi Fischer, on behalf
of Joris Steyn.
Committed on 23/09/2013 at 17:27.
Pushed by fischer into branch 'master'.

Fix crash when adding entity constraints

The root cause of this crash is not checking for a valid index when retrieving
the item from the QList. We should at least check that value before calling
at().

The patch I propose adds this check and also fixes the problem causing the
index to be wrong in the first place (like Arash Abedinzadeh described).
Related: bug 237992, bug 257540, bug 302120, bug 322541

M  +12   -11   umbrello/dialogs/classifierlistpage.cpp
M  +1    -1    umbrello/dialogs/classifierlistpage.h
M  +9    -0    umbrello/dialogs/constraintlistpage.cpp
M  +1    -0    umbrello/dialogs/constraintlistpage.h

http://commits.kde.org/umbrello/8eb9a5457ca292712c75ca5efbc4bf5ff2f88afc

-- 
You are receiving this mail because:
You are the assignee for the bug.