[Uml-devel] [PATCH] Avoid recursion in UMLClassifier::getOpList

[Ralf Habacker]

Am 27.05.2013 15:56, schrieb Martin Briza:
> Hi everybody,
>
> I prepared a simple patch to fix 
> https://bugs.kde.org/show_bug.cgi?id=306785 to stop the infinite 
> recursion and use a stack instead.
> Please note the root problem here is still present - data incosistency.

> Running with the reproducer prints a few "is parent of itself" error 
> messages. As I'm not a seasoned Umbrello developer, I couldn't dwell 
> deeper into the issue so I'm leaving the decision of what to do with 
> it (and my patch) up to you.

I think the best for know is to fix the crash and let developers give 
information about this issue in the debug log.
Then it would make sense to take a look if the gui can be fixed to avoid 
such issues. It is easy to create such recursive inheritence in the gui 
- see appended testcase.

BTW: I applied a similar patch which preserves the operations inherited 
from deeper classes.

Regards
Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20130528/c8fe5889/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testcase-two-class-inheritance.xmi
Type: application/x-uml
Size: 21002 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20130528/c8fe5889/attachment.bin>