[Uml-devel] KDE/kdesdk/umbrello/umbrello/dialogs

Ralf Habacker ralf.habacker at gmail.com
Sat Mar 24 15:16:05 UTC 2012


SVN commit 1286948 by habacker:

Removed comment.

For every widget attribute there is now a related 'changed' signal,
which ensures the propagation of changes into the widget.
Also having single signals avoids duplicates changes in the history.

 M  +0 -8      umlviewdialog.cpp  


--- trunk/KDE/kdesdk/umbrello/umbrello/dialogs/umlviewdialog.cpp #1286947:1286948
@@ -180,14 +180,6 @@
     {
         uDebug() << "setting colors ";
         m_pStylePage->updateUMLWidget();
-        /* FIXME: updateUMLWidget uses UMLScene::setOptions() to set back m_options
-         * into UMLScene (as also done for m_pageDisplayItem below) so theoretical
-         * the following code would be obsolate.
-         * The problems is that setOptions() do not signal UMLScene that options has
-         * been changed. There is a signal UMLscene::sigColorChanged(), but this signal
-         * is limited to color only changes. There is no common way to say UMLScene, that
-         * one or all options has been changed.
-         */
         m_pView->umlScene()->setLineWidth( m_options.uiState.lineWidth );
         m_pView->umlScene()->setUseFillColor( m_options.uiState.useFillColor );
         m_pView->umlScene()->setTextColor( m_options.uiState.textColor );




More information about the umbrello-devel mailing list