[Uml-devel] KDE/kdesdk/umbrello/umbrello/codeimpwizard

[Andi Fischer]

Hi Oliver,
Okay, then it is not so simple.
Did your fix solve the problem "signal not found"?
If yes then let it as it is.
If no then revert and find another fix ;-)

Regards,

Andi

---- "oliver.kellogg at t-online.de" <oliver.kellogg at t-online.de> schrieb:
> Hi Andi,
> 
> Ouch. I didn't know about that.
> I just saw some warning message about "signal not found" and that prompted my change.
> I'll revert the commit tonight (gotta go now) unless you want to revert it yourself right away?
> 
> Thanks for noticing,
> 
>  Oliver
> 
> -----Original message -----
> Von: Andi Fischer <andi.fischer at hispeed.ch>
> An: Oliver Kellogg <okellogg at users.sourceforge.net>
> Cc: umbrello-devel at kde.org
> Betreff: Re: [Uml-devel] KDE/kdesdk/umbrello/umbrello/codeimpwizard
> Datum: Mon, 13 Feb 2012 07:35:32 +0100
> 
> 
> ---- Oliver Kellogg <okellogg at users.sourceforge.net> schrieb:
> > SVN commit 1279697 by okellogg:
> > 
> > Constructor: In the connect(), align profile of askQuestion() / questionAsked() with declarations in codeimpthread.h
> > 
> >  M  +2 -2      codeimpthread.cpp  
> > 
> > 
> > --- trunk/KDE/kdesdk/umbrello/umbrello/codeimpwizard/codeimpthread.cpp #1279696:1279697
> > @@ -34,8 +34,8 @@
> >    : QObject(parent),
> >      m_file(file)
> >  {
> > -    connect(this, SIGNAL(askQuestion(QString,int)),
> > -            this, SLOT(questionAsked(QString,int)));
> > +    connect(this, SIGNAL(askQuestion(const QString&,int&)),
> > +            this, SLOT(questionAsked(const QString&,int&)));
> >  }
> >  
> 
> Hi Oliver,
> 
> Are you sure?
> 
> Have a look at
> 
> http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/
> 
> Regards,
> 
> Andi