[Uml-devel] branches/work/soc-umbrello-2011/umbrello/newcanvas

[Camila Ayres]

Hi

Ok, I will fix that. thanks for the warning.


Regards,

Camila






On Tue, May 10, 2011 at 1:44 PM, Andi Fischer <andi.fischer at hispeed.ch> wrote:
> Am 10.05.2011 05:05, schrieb Camila San Martin Ayres:
>>
>> SVN commit 1231074 by ayres:
>>
>>
>> --- branches/work/soc-umbrello-2011/umbrello/newcanvas/newscene.h
>> #1231073:1231074
>> @@ -1,3 +1,13 @@
>>
>> +/***************************************************************************
>> + *   This program is free software; you can redistribute it and/or modify
>>  *
>> + *   it under the terms of the GNU General Public License as published by
>>  *
>> + *   the Free Software Foundation; either version 2 of the License, or
>>   *
>> + *   (at your option) any later version.
>>   *
>> + *
>>   *
>> + *   copyright (C) 2002-2010
>>   *
>> + *   Umbrello UML Modeller Authors<uml-devel at uml.sf.net>
>>   *
>> +
>> ***************************************************************************/
>> +
>>  #ifndef NEWSCENE_H
>>  #define NEWSCENE_H
>>
>> @@ -67,10 +77,10 @@
>>      QPointF getPos() const;
>>      void setPos(const QPointF&pos);
>>
>> -    QColor gridDotColor() const;
>> +    QColor getGridDotColor() const;
>>      void setGridDotColor(const QColor&gridColor);
>>
>> -    QColor fillColor() const;
>> +    QColor getFillColor() const;
>>      void setFillColor(const QColor&color);
>
> Hi Camila,
> Since two years we are removing the "get"  from the getters.
> This is the same style as in the Qt API. For example have a look at QObject
> - there is a setParent() and a parent().
>
> So please don't re-add the "get".  We are all so lazy ;-)
>
> Thanks.
>
> Andi
>
>
>
>