[Uml-devel] KDE/kdesdk/umbrello/umbrello

Andi Fischer andi.fischer at hispeed.ch
Wed Jul 23 19:36:33 UTC 2008


SVN commit 837100 by fischer:

Fixing Krazy complaints - using QChars instead of QStrings.

 M  +1 -1      codegenerator.cpp  
 M  +2 -2      codegenerators/cppwriter.cpp  
 M  +1 -1      codegenerators/simplecodegenerator.cpp  
 M  +1 -1      codegenerators/xmlschemawriter.cpp  
 M  +2 -2      codeimport/adaimport.cpp  
 M  +2 -2      codeimport/import_utils.cpp  
 M  +1 -1      codeimport/javaimport.cpp  
 M  +1 -1      uml.cpp  
 M  +1 -1      umlview.cpp  


--- trunk/KDE/kdesdk/umbrello/umbrello/codegenerator.cpp #837099:837100
@@ -492,7 +492,7 @@
         if (!pathDir.exists())
         {
             // ugh. dir separator here is UNIX specific..
-            QStringList dirs = pathDir.absolutePath().split("/");
+            QStringList dirs = pathDir.absolutePath().split('/');
             QString currentDir;
 
             QStringList::iterator end(dirs.end());
--- trunk/KDE/kdesdk/umbrello/umbrello/codegenerators/cppwriter.cpp #837099:837100
@@ -581,7 +581,7 @@
     // need to resolve for using with MAC/WinDoze eventually I assume
     if (comment.contains(QRegExp("\n"))) {
 
-        QStringList lines = comment.split( "\n" );
+        QStringList lines = comment.split( '\n' );
         for (int i= 0; i < lines.count(); i++)
         {
             cpp << myIndent << "// " << lines[i] << m_endl;
@@ -1200,7 +1200,7 @@
     if(text.isEmpty())
         return;
 
-    QStringList lines = text.split( "\n" );
+    QStringList lines = text.split( '\n' );
     for (int i= 0; i < lines.count(); i++)
         stream << indent << lines[i] << m_endl;
 }
--- trunk/KDE/kdesdk/umbrello/umbrello/codegenerators/simplecodegenerator.cpp #837099:837100
@@ -115,7 +115,7 @@
         // does our complete output directory exist yet? if not, try to create it
         if (!pathDir.exists())
         {
-            QStringList dirs = pathDir.absolutePath().split("/");
+            QStringList dirs = pathDir.absolutePath().split('/');
             QString currentDir = "";
 
             QStringList::iterator end(dirs.end());
--- trunk/KDE/kdesdk/umbrello/umbrello/codegenerators/xmlschemawriter.cpp #837099:837100
@@ -527,7 +527,7 @@
     XMLschema<<indent<<"<!-- ";
     if (comment.contains(QRegExp("\n"))) {
         XMLschema<<m_endl;
-        QStringList lines = comment.split( "\n" );
+        QStringList lines = comment.split( '\n' );
         for (int i= 0; i < lines.count(); i++)
             XMLschema<<indent<<"     "<<lines[i]<<m_endl;
 
--- trunk/KDE/kdesdk/umbrello/umbrello/codeimport/adaimport.cpp #837099:837100
@@ -187,7 +187,7 @@
             return false;
         }
         while (++m_srcIndex < srcLength && m_source[m_srcIndex] != ";") {
-            QStringList components = m_source[m_srcIndex].toLower().split(".");
+            QStringList components = m_source[m_srcIndex].toLower().split('.');
             const QString& prefix = components.first();
             if (prefix == "system" || prefix == "ada" || prefix == "gnat" ||
                 prefix == "interfaces" || prefix == "text_io" ||
@@ -209,7 +209,7 @@
     }
     if (keyword == "package") {
         const QString& name = advance();
-        QStringList parentPkgs = name.toLower().split(".");
+        QStringList parentPkgs = name.toLower().split('.');
         parentPkgs.pop_back();  // exclude the current package
         parseStems(parentPkgs);
         UMLObject *ns = NULL;
--- trunk/KDE/kdesdk/umbrello/umbrello/codeimport/import_utils.cpp #837099:837100
@@ -92,7 +92,7 @@
     if (comment.isEmpty())
         return comment;
 
-    QStringList lines = comment.split("\n");
+    QStringList lines = comment.split('\n');
     QString& first = lines.first();
     QRegExp wordex("\\w");
     if (first.startsWith("/*")) {
@@ -167,7 +167,7 @@
             if (typeName.contains("::")) {
                 components = typeName.split("::");
             } else if (typeName.contains(".")) {
-                components = typeName.split(".");
+                components = typeName.split('.');
             }
             if (components.count() > 1) {
                 typeName = components.back();
--- trunk/KDE/kdesdk/umbrello/umbrello/codeimport/javaimport.cpp #837099:837100
@@ -234,7 +234,7 @@
     if (keyword == "package") {
         m_currentPackage = advance();
         const QString& qualifiedName = m_currentPackage;
-        QStringList names = qualifiedName.split(".");
+        QStringList names = qualifiedName.split('.');
         for (QStringList::Iterator it = names.begin(); it != names.end(); ++it) {
             QString name = (*it);
             UMLObject *ns = Import_Utils::createUMLObject(Uml::ot_Package,
--- trunk/KDE/kdesdk/umbrello/umbrello/uml.cpp #837099:837100
@@ -1852,7 +1852,7 @@
     }
     preselectedExtension.append("\n*|" + i18n("All Files"));
 #ifdef Q_WS_WIN
-    QStringList extList = preselectedExtension.split("|");
+    QStringList extList = preselectedExtension.split('|');
     QStringList fileList = QFileDialog::getOpenFileNames(this, i18n("Select Code to Import"),    //krazy:exclude=qclasses
                                 "", extList[1] );
 #else
--- trunk/KDE/kdesdk/umbrello/umbrello/umlview.cpp #837099:837100
@@ -3473,7 +3473,7 @@
                 QDomNode gnode = e.firstChild();
                 QDomElement gelem = gnode.toElement();
                 QString csv = gelem.text();
-                QStringList dim = csv.split(",");
+                QStringList dim = csv.split(',');
                 x = dim[0].toInt();
                 y = dim[1].toInt();
                 w = dim[2].toInt();




More information about the umbrello-devel mailing list