[Uml-devel] KDE/kdesdk/umbrello/umbrello

[David Faure]

On Tuesday 16 October 2007, Christian Ehrlicher wrote:
> and here the missing linepath.cpp/.h , ported to QList<foo*>
Wow you must have gotten a hell of a conflict...

> @@ -269,7 +270,7 @@
>  
>  
>      /* remove the segment from the list */
> -    m_LineList.remove( pointIndex );
> +    m_LineList.removeAt( pointIndex );
>  
>      return true;
>  }

Hmm. When possible it's better to use QList<Foo> than QList<Foo *>. Of course depending
on what Foo is, but if it can be copied, then it's simpler+safer.
For instance, the above call deleted the item in qt3, so now there's a leak, unless I'm missing something?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).