[Uml-devel] KDE/kdesdk/umbrello/umbrello

[Sharan Rao]

SVN commit 721197 by sharan:

Fixed weird bug in which menu entries ( like, "New->Entity Relationship Diagram", "New->Component Diagram" etc ) used to disappear 
suddenly.
Scenario in which this used to happen:
1. Right Click on the folder "Use Case View" -> "New" -> "Use Case Diagram"
2. Right Click on the folder "Component View" -> "New" -> "Component Diagram"
3. Right Click on the folder "Use Case View"-> "New" -> ...   ( Where did the entry "Use Case Diagram" disappear ???? )

The action used to be deleted in the destructor of ListPopupMenu :O ( as it used to maintain a local copy of the pointer to the 
action ). 



 M  +5 -4      listpopupmenu.cpp  


--- trunk/KDE/kdesdk/umbrello/umbrello/listpopupmenu.cpp #721196:721197
@@ -641,7 +641,8 @@
     case mt_Component_Diagram:
         {
             QAction* act = UMLApp::app()->actionCollection()->action("new_component_diagram");
-            m_actions[m] = act;
+            //don't keep a local copy of pointer which resides somewhere else ( in this case - in actionCollection() )
+            //m_actions[m] = act;
             menu->addAction(act);
         }
         break;
@@ -651,7 +652,7 @@
     case mt_Deployment_Diagram:
         {
             QAction* act = UMLApp::app()->actionCollection()->action("new_deployment_diagram");
-            m_actions[m] = act;
+            //m_actions[m] = act;
             menu->addAction(act);
         }
         break;
@@ -667,7 +668,7 @@
     case mt_EntityRelationship_Diagram:
         {
             QAction* act = UMLApp::app()->actionCollection()->action("new_entityrelationship_diagram");
-            m_actions[m] = act;
+            //m_actions[m] = act;
             menu->addAction(act);
         }
         break;
@@ -683,7 +684,7 @@
     case mt_UseCase_Diagram:
         {
             QAction* act = UMLApp::app()->actionCollection()->action("new_use_case_diagram");
-            m_actions[m] = act;
+            //m_actions[m] = act;
             menu->addAction(act);
         }
         break;