[Uml-devel] branches/KDE/3.5/kdesdk/umbrello/umbrello

[Oliver Kellogg]

SVN commit 672504 by okellogg:

signalUMLObjectCreated(): This is the wrong place to call setModified().
That should be done at the callers when object creation and all its side
effects (e.g. new widget in view, new list view item, etc.) is finished.


 M  +6 -2      umldoc.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/umbrello/umldoc.cpp #672503:672504
@@ -1184,8 +1184,12 @@
 
 void UMLDoc::signalUMLObjectCreated(UMLObject * o) {
     emit sigObjectCreated(o);
-    if (!m_bLoading)
-        setModified(true);
+    /* This is the wrong place to do:
+               setModified(true);
+       Instead, that should be done by the callers when object creation and all
+       its side effects (e.g. new widget in view, new list view item, etc.) is
+       finalized.
+     */
 }
 
 void UMLDoc::setName(const QString& name) {