[Uml-devel] KDE/kdesdk/umbrello/umbrello

[Oliver Kellogg]

SVN commit 653147 by okellogg:

Forward declaration of UMLAttribute will not do:

Building CXX object CMakeFiles/umbrello.dir/dialogs/codeviewerdialog.o
/Qt-4.3.0beta/include/Qt/q3ptrlist.h: In member function ‘void Q3PtrList<type>
   ::deleteItem(void*) [with type = UMLAttribute]’:
codeviewerdialog.moc:68:   instantiated from here
/Qt-4.3.0beta/include/Qt/q3ptrlist.h:140: warning: possible problem detected
   in invocation of delete operator:
/Qt-4.3.0beta/include/Qt/q3ptrlist.h:140: warning: invalid use of incomplete
   type ‘struct UMLAttribute’
umlattributelist.h:18: warning: forward declaration of ‘struct UMLAttribute’
/Qt-4.3.0beta/include/Qt/q3ptrlist.h:140: note: neither the destructor nor
   the class-specific operator delete will be called, even if they are
   declared when the class is defined.


 M  +1 -2      umlattributelist.h  


--- trunk/KDE/kdesdk/umbrello/umbrello/umlattributelist.h #653146:653147
@@ -14,8 +14,7 @@
 
 #include <q3ptrlist.h>
 
-// forward declaration
-class UMLAttribute;
+#include "attribute.h"
 
 //typedef QPtrList<UMLAttribute> UMLAttributeList;
 typedef Q3PtrListIterator<UMLAttribute> UMLAttributeListIt;