[Uml-devel] Real fix for loading of collaboration diagram message widgets

[Achim Spangler]

Hi,

I found now the real problem of loading collaboration diagram message widgets.

The AssociationWidget::loadFromXMI() didn't have an appropriate special case 
handling for the collaboration diagram associations. The old implementation 
simply regarded everything which didn't refer an ot_Attribute or 
ot_EntityAttribute as a "normal" association. 

BUT this isn't true for collaboration diagram message widgets.
THERE the xmi.id of the <assocwidget> refers to the UID of the UML:Operation. 
Thus I added the handling of collaboration diagram message widgets the same 
way the special case of attribute assocs.

NOW it really works.

So please merge the attached fix as soon as possible!

One request for future:
Please try ALL sorts of diagrams create->store->load on any further change of 
XMI syntax and loading algorithms. It would be very fine, when base functions 
of umbrello like loading of collaboration diagrams wouldn't get affected by 
regressions.


Thanks,
Achim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FixCollaborationAssocWidget.diff
Type: text/x-diff
Size: 3569 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20061121/8e8cfe4d/attachment.bin>