[Uml-devel] [Bug 107347] program design: separation of responsibilities

[Oliver Kellogg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=107347         




------- Additional Comments From okellogg users sourceforge net  2006-07-16 21:59 -------
While working on a completely unrelated issue (wish 114547), all of a sudden
I get this crash:
[KCrash handler]
#4  0x40ffdecb in QString::QString(QString const&) ()
   from /usr/lib/qt3/lib/libqt-mt.so.3
#5  0x08136f50 in GeneralState (this=0xbfffeef0, _ctor_arg= 0x8457c8c)
    at uml.h:1001
#6  0x08136d88 in OptionState (this=0xbfffeef0, _ctor_arg= 0x8457c8c)
    at uml.h:1001
#7  0x08136a24 in UMLApp::getOptionState() (this=0x8457ab8) at uml.h:1001
#8  0x081c0c59 in UMLListView::setDocument(UMLDoc*) (this=0x84eaf90, 
    d=0x84647b8)
    at /home/kellogg/kdesdk-3.5-branch/umbrello/umbrello/umllistview.cpp:850
#9  0x081a557a in UMLApp::initView() (this=0x8457ab8)
    at /home/kellogg/kdesdk-3.5-branch/umbrello/umbrello/uml.cpp:469
#10 0x081a1244 in UMLApp (this=0x8457ab8, name=0x0)
    at /home/kellogg/kdesdk-3.5-branch/umbrello/umbrello/uml.cpp:99
#11 0x0817c643 in main (argc=1, argv=0xbffff224) at main.cpp:101
#12 0x415158ae in __libc_start_main () from /lib/libc.so.6

How could this ever work?
At #7 we're calling UMLApp::app()->getOptionState() at a time when
the app() instance is not even finished being constructed.
I will move the {set,get}OptionState() methods to Settings.