[Uml-devel] [Bug 130792] importing java class (enum pattern) cause umbrello to hang

[JP Fournier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130792         




------- Additional Comments From jfournier121 rogers com  2006-07-15 18:24 -------
The patch below seems to address the crashiness associated with this bug.

regards

jp

jape puma:~/tmp/uml/kdesdk-561582$ diff -c umbrello-561582/umbrello/javaimport.cpp umbrello/umbrello/javaimport.cpp
*** umbrello-561582/umbrello/javaimport.cpp     2006-07-15 07:24:49.000000000 -0400
--- umbrello/umbrello/javaimport.cpp    2006-07-15 12:17:29.000000000 -0400
***************
*** 285,297 ****
          return false;
      }
      QString typeName = joinTypename();
!     QString name;
!     if (typeName == m_klass->getName()) {
          // Constructor.
          name = typeName;
          typeName = QString::null;
      } else {
!         name = advance();
      }
      if (name.contains( QRegExp("\\W") )) {
          kdError() << "importJava: expecting name in " << name << endl;
--- 285,299 ----
          return false;
      }
      QString typeName = joinTypename();
!     QString name = advance();
!     QString nextToken ;
!     if ((typeName == m_klass->getName()) && (name == "(") ) {
          // Constructor.
+         nextToken = name;
          name = typeName;
          typeName = QString::null;
      } else {
!         nextToken = advance();
      }
      if (name.contains( QRegExp("\\W") )) {
          kdError() << "importJava: expecting name in " << name << endl;
***************
*** 302,308 ****
          kdError() << "importJava: no class set for " << name << endl;
          return false;
      }
-     QString nextToken = advance();
      if (nextToken == "(") {
          // operation
          UMLOperation *op = Import_Utils::makeOperation(m_klass, name);
--- 304,309 ----