[Uml-devel] [Bug 98369] hangs if a containment connection is drawn between a package and an interface, if there already exists one in the other direction

Oliver Kellogg okellogg at users.sourceforge.net
Sat Oct 15 11:52:36 UTC 2005


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=98369         
okellogg users sourceforge net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From okellogg users sourceforge net  2005-10-15 20:50 -------
SVN commit 470948 by okellogg:

allowAssociation(Association_Type,UMLWidget*,UMLWidget*,bool):
 Prevent mutual compositions and containments.
BUG:98369


 M  +4 -4      assocrules.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/umbrello/assocrules.cpp #470947:470948
 @ -138,15 +138,15  @
     case at_Coll_Message:
     case at_Aggregation:
     case at_Relationship:
-    case at_Composition:
-    case at_Containment:
-        return true;//doesn't matter whats already connected to widget
+        return true;  // doesn't matter what's already connected to widget
         break;
 
+    case at_Composition:   // can't have mutual composition
+    case at_Containment:   // can't have mutual containment
     case at_Generalization://can have many sub/super types but can't sup/sub each
         while( ( assoc = it.current() ) ) {
             if( ( widgetA == assoc -> getWidget(A) || widgetA == assoc -> getWidget(B) )
-                    && assoc -> getAssocType() == at_Generalization )
+                    && assoc->getAssocType() == assocType )
                 return false;
             ++it;
         }




More information about the umbrello-devel mailing list