[Uml-devel] [Bug 56184] Umbrello XMI file format doesn't conform with uml13.dtd

[Oliver Kellogg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=56184         




------- Additional Comments From okellogg users sourceforge net  2005-11-30 07:58 -------
SVN commit 484294 by okellogg:

First set of changes motivated by comments from Tom Morris for loading
Umbrello files into ArgoUML-0.20alpha2.
CCBUG:56184


 M  +1 -0      THANKS  
 M  +2 -1      umbrello/attribute.cpp  
 M  +1 -1      umbrello/classifier.cpp  
 M  +10 -6     umbrello/umlobject.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/THANKS #484293:484294
 @ -46,6 +46,7  @
 martin <mv123q3  hotmail com>
 Rene Meyer <Rene.Meyer  sturmit de>
 Laurent Montel <montel  kde org>
+Tom Morris <tfmorris  gmail com>
 Lutz Mueller <lutz.mueller  gmx de>
 Heiko Nardmann <heiko.nardmann  onlinehome de>
 Dimitri Ognibene <ognibened  yahoo it>
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/attribute.cpp #484293:484294
 @ -188,7 +188,8  @
     } else {
         attributeElement.setAttribute( "type", ID2STR(m_pSecondary->getID()) );
     }
-    attributeElement.setAttribute( "initialValue", m_InitialValue );
+    if (! m_InitialValue.isEmpty())
+        attributeElement.setAttribute( "initialValue", m_InitialValue );
     qElement.appendChild( attributeElement );
 }
 
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/classifier.cpp #484293:484294
 @ -775,7 +775,7  @
             genElement.appendChild(gElem);
         }
         if (genElement.hasChildNodes())
-            qElement.appendChild( genElement );
+            classifierElement.appendChild( genElement );
     }
 
     // save attributes
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/umlobject.cpp #484293:484294
 @ -471,12 +471,16  @
     }
     qElement.setAttribute( "xmi.id", ID2STR(m_nId) );
     qElement.setAttribute( "name", m_Name );
-    Uml::IDType nmSpc;
-    if (m_pUMLPackage)
-        nmSpc = m_pUMLPackage->getID();
-    else
-        nmSpc = UMLApp::app()->getDocument()->getModelID();
-    qElement.setAttribute( "namespace", ID2STR(nmSpc) );
+    if (m_BaseType != Uml::ot_Operation &&
+            m_BaseType != Uml::ot_Role &&
+            m_BaseType != Uml::ot_Attribute) {
+        Uml::IDType nmSpc;
+        if (m_pUMLPackage)
+            nmSpc = m_pUMLPackage->getID();
+        else
+            nmSpc = UMLApp::app()->getDocument()->getModelID();
+        qElement.setAttribute( "namespace", ID2STR(nmSpc) );
+    }
     if (! m_Doc.isEmpty())
         qElement.setAttribute( "comment", m_Doc );  //CHECK: uml13.dtd compliance
 #ifdef XMI_FLAT_PACKAGES