[Uml-devel] some kdetestscripts fixes

[Peeter Russak]

Hi,

I've lost my ssh key, so please anyone else commit attached patch. It 
contains fixes for cases found by kdetestscripts isempty and listend. I 
think I'll play more with these scripts when I'll get some more free time.

# Name: Empty char* comparison
# Description: Finds usage where a QString is compared to "" where using 
.isEmpty() should be used because it is much faster.
# ToResolve: Change code to use string.isEmpty()  In the event that it 
is a std::string change to empty()

# Name: .end() call in for loop
# Description: When iteratoring through a list the value of end() should 
be cached to avoid the unnecessary creation of the  temporary variable. 
See: <a 
href="http://developer.kde.org/documentation/other/mistakes.html">Iterators</a>
# ToResolve: Create temporary variable (preferably const) outside of for 
loop to compare against.

-- 
Peeter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: umbrello-opt1.patch
Type: text/x-patch
Size: 31086 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20041031/87d224f3/attachment.patch>