[Uml-devel] [Bug 92116] New: off-by-one bug with moving list items in Umbrello

[Stefan Walter]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=92116        
           Summary: off-by-one bug with moving list items in Umbrello
           Product: umbrello
           Version: unspecified
          Platform: FreeBSD Ports
        OS/Version: FreeBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: umbrello-devel.kde.org
        ReportedBy: sw gegenunendlich de


Version:            (using KDE KDE 3.3.0)
Installed from:    FreeBSD Ports
Compiler:          gcc 3.4.2 
OS:                FreeBSD

When changing the order of operations or attributes of a class, using the
dialog's down button changes the order of items in the dialog list correctly,
but moves the item in the class itself down two slots (i.e. one too far).

Create a class with attributes and/or operations, then double-click on the
class to open its properties dialog. Choose 'operations' or 'attributes'.
Choose one of the attributes/operations and click on the 'down' arrow. The
chosen item will be moved down by one in the list, but two in the diagram.

The following patch fixes Umbrello's behaviour:

--- umbrello/umbrello/dialogs/classifierlistpage.cpp.old	Mon Oct 25 16:09:31 2004
+++ umbrello/umbrello/dialogs/classifierlistpage.cpp	Mon Oct 25 16:09:56 2004
 @ -348,7 +348,7  @
 	//now change around in the list
 	UMLClassifierListItem* currentAtt = getItemList().at( index );
 	takeClassifier(currentAtt);
-	addClassifier(currentAtt, index + 2);
+	addClassifier(currentAtt, index + 1);
 	slotClicked( item );
 }