[Uml-devel] kdesdk/umbrello/umbrello

[Oliver Kellogg]

CVS commit by okellogg: 

setSelected(): Hotfix against missing selection markers on at_Coll_Message.


  M +12 -2     associationwidget.cpp   1.132


--- kdesdk/umbrello/umbrello/associationwidget.cpp  #1.131:1.132
@@ -2594,5 +2594,4 @@ void AssociationWidget::updateRegionLine
 void AssociationWidget::setSelected(bool _select /* = true */) {
         m_bSelected = _select;
-        m_LinePath.setSelected( _select );
         if( m_pName)
                 m_pName-> setSelected( _select );
@@ -2609,5 +2608,10 @@ void AssociationWidget::setSelected(bool
         if( m_role[B].m_pChangeWidget)
                 m_role[B].m_pChangeWidget-> setSelected( _select );
-        // Update the docwindow for this association.
+        /**
+         * @fixme MYSTERY:
+         *        If the following code is activated and the m_LinePath.setSelected()
+         *        precedes it then the blue selection markers sometimes disappear
+         *        (notably on messages in collaboration diagrams.)
+        //Update the docwindow for this association.
         // This is done last because each of the above setSelected calls
         // overwrites the docwindow, but we want the main association doc
@@ -2618,4 +2622,10 @@ void AssociationWidget::setSelected(bool
         } else
                 m_pView -> updateDocumentation( true );
+         */
+        /** @fixme Had to pull the m_LinePath.setSelected() call down here
+         *         because otherwise the blue selection markers would not show
+         *         when selecting collaboration messages.
+         */
+        m_LinePath.setSelected( _select );
 }