[Uml-devel] kdesdk/umbrello/umbrello

Oliver Kellogg okellogg at users.sourceforge.net
Sun Jul 18 23:14:01 UTC 2004


CVS commit by okellogg: 

activateView: Unused, remove.
addUMLObjectPaste: Deactivate foggy code.


  M +4 -8      umldoc.cpp   1.165
  M +0 -8      umldoc.h   1.69


--- kdesdk/umbrello/umbrello/umldoc.cpp  #1.164:1.165
@@ -2486,4 +2486,7 @@ bool UMLDoc::addUMLObjectPaste(UMLObject
                 return false;
         }
+        /**** What is this code doing?
+              We know for sure that the UMLObject that has just been cut
+              is found, thus this call is totally pointless.
         UMLObject * temp = findUMLObject( Obj -> getName() );
         if( temp ) {
@@ -2492,4 +2495,5 @@ bool UMLDoc::addUMLObjectPaste(UMLObject
                 return true;
         }
+         ****/
         int result =  assignNewID(Obj->getID());
         Obj->setID(result);
@@ -2594,12 +2598,4 @@ bool UMLDoc::addUMLView(UMLView * pView 
 }
 
-bool UMLDoc::activateView ( int /*viewID*/ ) {
-        //CHECK: Obsolete ?
-        bool status = true;
-
-        m_bLoading = false;
-        return status;
-}
-
 bool UMLDoc::activateAllViews() {
         bool status = true;

--- kdesdk/umbrello/umbrello/umldoc.h  #1.68:1.69
@@ -780,12 +780,4 @@ public:
 
         /**
-         * Activate a diagram after loading a new document
-         *
-         * @param viewID        ID of the UMLView to activate.
-         * @return      True on successful activation.
-         */
-        bool activateView ( int viewID );
-
-        /**
          * Activate all the diagrams/views after loading so all their
          * widgets keep their IDs.






More information about the umbrello-devel mailing list