[Uml-devel] Re: [Bug 54816] associations not pasted after a copy

Brian Thomas brian.thomas at gsfc.nasa.gov
Mon Jan 5 09:08:02 UTC 2004

On Monday 05 January 2004 07:59 am, Oliver Kellogg wrote:
> n AssociationWidget::setUMLAssociation(), I again
> had to take out the
>   if (m_pAssociation->nrof_parent_widgets == 0)
>     m_pAssociation->deleteLater();
> Does this cause a problem for you?
> If so then please raise a separate PR at bugs.kde.org.
> Thanks,

	Hi Oliver, All,

	I've been away on vacation.. back today. Although I havent done more than
	skim over the mail I have got, I do see some serious problems related
	to the association code changes.

	1. Why, this late in the development cycle, are we changing associations
	so heavily. This is causing me some headaches (as per in the next bullet..)

	2. Yes, *not* deleting associations is bad. It very much will cause a problem
	with code generation as well as other things. In terms of code generation, you 
	will have components lying around that arent used (they only delete themselves
	after the parent association dies), and will throw a core dump when the parent 
	is deleted (aka the CodeClassField crashes, I believe). Second, in general terms, 
	this is very bad as it will be a source of a memory leak (unused associations lying 
	around in memory).

	So.. why are cut and paste of associations so important vs being able to have no
	crashes/memory leak. Surely there is a better way to fix the cut and paste. If not,
	or the fix wont be simple, then from my point of view, it is *far* better to remove cut 
	n paste of associations for the 3.2 release rather than the other way around.

	I'll try to take a more in depth look at the code, and the changes made, later today
	and provide feedback/patches as appropriate.



More information about the umbrello-devel mailing list