[Uml-devel] [Bug 73632] attribute comments with sqlwriter produces invalid SQL

[Sebastian Stein]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=73632      




------- Additional Comments From seb_stein at gmx.de  2004-02-01 19:15 -------
Subject: Re: [Uml-devel]  New: umbrello sqlwriter output is anything but SQL..

Riku Voipio <nchip at kos.to> [040128 00:31]:
> http://bugs.kde.org/show_bug.cgi?id=73632      
>            Summary: umbrello sqlwriter output is anything but SQL..
> ...
> The umbrello generate code -> SQL does not produce anything
> meaningfull. comments get mixed between declarations

Maybe this is a feature. Or how do you add things like NOT NULL? If you use
the comment, you can add it directly behind the column name and type.

> and most declarations are not separated by "," like they should.

This seems to be true sometimes, e.g. if you create a empty table, so a
class without attributes.

>         CONSTRAINT  FOREIGN KEY (1) REFERENCES blacklist(0..*)

You also have to give the association a name, this would be the key. The (1)
is wrong, I think it should point to the column in the source table, which
can be set as a role.

Also, I don't understand, why the constraint is added to both tables. I
think it should only be added to 1 table (where the rhombus is connected
to).

So, maybe you can rework your patch, I won't apply it now. I think the
comment thing is a feature, even so it is not very clear to the user.

Maybe you can start with making a class diagram and write down what sql code
you expect. We could use this file for future test cases. Please also have a
look at the properties of the association between the classes. You can set
an association name and the roles. I think the roles are misinterpreted at
the moment as well, because instead of the names the count or something like
this is added to the sql output.

Thanks for your help,

Steinchen