[Uml-devel] [Bug 63897] Crash when trying to associate two classes in a collaboration diagram

[Jonathan Riddell]

On Thu, Sep 18, 2003 at 04:30:04PM +0200, David Faure wrote:
> Good timing, I was about to write to you :)
> Associations are indeed saved and loaded just fine, now.
> 
> But now I get a crash when trying to set a text on an association. The problem is,
> I'm not sure exactly how I'm supposed to do that. But I tried "New operation",
> and this time I got a dialog. Upon closing it, I got a crash:
> 
> #2  0x08126648 in FloatingText::slotMenuSelection(int) (this=0x846d868, sel=1940)
>     at /mnt/devel/kde/kdecvs/kdesdk/umbrello/umbrello/floatingtext.cpp:144
> 144                                     m_pMessage->setOperation( newOperation->toString(st_NoSigNoScope) );

Select operation and New Operation should work properly in
Collaboration Diagrams and Sequence Diagrams.


On Thu, Sep 18, 2003 at 04:39:50PM +0200, David Faure wrote:
> After looking at the source, I found out that I could do what I wanted (set
> a text on an association in a collaboration diagram) by using
> "set sequence number". This is really confusing (since I'm entering a text,
> not a number), but it works.
> 
> There are many uses of null pointers in umbrello, I wonder if the design is right.
> Shouldn't "text in a message" and "text in an association" be subclasses of
> FloatingText, to avoid having to check "in which case are we?" in each method
> of FloatingText? Apologies if this makes no sense, I don't know the overall
> design of umbrello (or else I'd be fixing those bugs myself :) It just seems far
> too common to have nil-pointer crashes currently...

Yes, there's probably quite a lot that should be changed about this
part of the code.

Also it ought to keep a reference to the actual operation so the label
changes when the operation name changes.

I found some more bugs, deleteing a sequence diagram message makes it
crash (it not immediatly then on the next move) and collaboration
diagram arrows are the wrong way round except, for some reason, on the
first arrow you make to an object widget.

I don't know if either of these two have anything to do with Luis
changes mentioned recently.

Jonathan Riddell