[Uml-devel] kdesdk/umbrello/umbrello

[Brian Thomas]

CVS commit by thomas: 

code cleanup: make addParm(attrib) reused by other addParm method. Also set default parameter scope to Public (this probably is not important since parameters shouldnt have 'scope', but oh well)


  M +4 -4      operation.cpp   1.12


--- kdesdk/umbrello/umbrello/operation.cpp  #1.11:1.12
@@ -14,4 +14,5 @@
 #include "attribute.h"
 #include "classifier.h"
+#include "umldoc.h"
 #include "dialogs/umloperationdialog.h"
 
@@ -42,10 +43,9 @@ UMLOperation::~UMLOperation() {
 ////////////////////////////////////////////////////////////////////////////////////////////////////
 void UMLOperation::addParm(QString type, QString name, QString initialValue, QString doc) {
-        UMLAttribute * a = new UMLAttribute(this, name, ++m_nUniqueID,type);
+        // make the new parameter (attribute) public, just to be safe
+        UMLAttribute * a = new UMLAttribute(this, name, ++m_nUniqueID,type, Uml::Public);
         a -> setDoc(doc);
         a -> setInitialValue(initialValue);
-        m_List.append(a);
-        emit modified();
-        connect(a,SIGNAL(modified()),this,SIGNAL(modified()));
+        addParm(a);
 }
 ////////////////////////////////////////////////////////////////////////////////////////////////////