[Uml-devel] valgrind output from umbrello (kde-cvs of 2003-05-17)

[Sebastian Stein]

Oliver Kellogg <Oliver.Kellogg at t-online.de> [030518 19:51]:
> I have no idea what valgrind is complaining about - everything seems to be
> initialized alright.
> (All of this is happening within a contructor - perhaps
> there are some restrictions with what may be done there?)
> 
> ==11874== Conditional jump or move depends on uninitialised value(s)
> ==11874==    at 0x80CE991: UMLListView::setDocument(UMLDoc *) 
> (umllistview.cpp:562)
> ==11874==    by 0x810C412: UMLApp::initView(void) (uml.cpp:420)
> ==11874==    by 0x81083EF: UMLApp::UMLApp(int, QWidget *, char const *) 
> (uml.cpp:88)
> ==11874==    by 0x811F859: main (main.cpp:50)

Let's look at the code:

void UMLListView::setDocument(UMLDoc *d) {
   if( m_doc && m_doc != d)
   {
      //disconnect signals from old doc and reset view
   }
 
We agree, that d isn't uninitialised. But m_doc might be. Because it isn't
initialized in the constructor.

I think this code snipset is very typical for the Umbrello code, because it
can be removed completly I think.

So if me no one can tell me why it should stay in the next days, I will
remove it (or of course you can do!).

Steinchen
-- 
Umbrello UML Modeller
Description     : UML diagram drawing tool for KDE with code generation
Homepage        : http://www.umbrello.org/