[Uml-devel] [Bug 53371] New diagram type: Component Diagram

[Carsten Pfeiffer]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=53371     




------- Additional Comments From carpdjih at mailbox.tu-berlin.de  2003-03-05 02:52 -------
Subject: Re: [Uml-devel] kdesdk/umbrello/umbrello

An important hint would have been, that you tried this after loading an (old) 
document.

Suggested patch attached. 

There were several problems.
1) UMLListView::init() is called multiple times during the lifetime of the 
UMLListView instance, which produced a memory leak and some connect()s 
accumulating.
2) The default listview items ("Logical View", "Use Case View", etc.) were 
created and destroyed at several places in the code. However they were not 
guaranteed to be created at all times (but being relied on all the time).

The deleteChildrenOf() calls could be factored out into a clear() method, 
cleaning up the view (cleaning up everything, but not destroying, or at least 
recreating the default items).

Please test/review.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPmVYk6WgYMJuwmZtAQHKZgf/SEgbL2SNOJBCQ9rfcehBXnpmQIjXr8tk
W+GkZwBgRPc5AYzOlA8QOEVoKCbn7jykxVCtemsmuUrKkcBNea7AfY0ck3Fnv5U/
fCMaao8OiJToPWZVwFCNjF4XDFi+zNALhMPGaPY6kuNM0JzFpRWe39E6IksbwCUh
XloKgFJQokOT21acN3teGJC8YfQPc/ckkXFVjNRVLxqlaCSN84mzQsRTiCV3wbYP
dZ9vPhQWrLacmmT/LmPvtzI159uOy1ofPG1qypKYpFX9QhNMG08lOlfU0hI6/hMD
yYoK8TV4PK5RqmA+iDZIqsXZU76DCVJu5A8cT/3PZO4XcFmSokz/tQ==
=2/LJ
-----END PGP SIGNATURE-----


Created an attachment (id=1106)
 --> (http://bugs.kde.org/attachment.cgi?id=1106&action=view)
patch-1

-- 
The University of Stirling is a university established in Scotland by
charter at Stirling, FK9 4LA.  Privileged/Confidential Information may
be contained in this message.  If you are not the addressee indicated
in this message (or responsible for delivery of the message to such
person), you may not disclose, copy or deliver this message to anyone
and any action taken or omitted to be taken in reliance on it, is
prohibited and may be unlawful.  In such case, you should destroy this
message and kindly notify the sender by reply email.  Please advise
immediately if you or your employer do not consent to Internet email
for messages of this kind.  Opinions, conclusions and other
information in this message that do not relate to the official
business of the University of Stirling shall be understood as neither
given nor endorsed by it.