[Uml-devel] Build error (cvs)

[Carsten Pfeiffer]

-----BEGIN PGP SIGNED MESSAGE-----

On Thursday 06 March 2003 09:55, Michel Hermier wrote:

Hiya,

> Yup, your right I forgot it Here it is.
> I prefer my patch to the solution you choosed in umldoc.h.
>
> Invoking this:
> > +namespace std {
> > +        class type_info;
> > +}
>
> Is not very portable in the sence that -If I don't make a mistake- the
> "old" declarations of the class type_info are not in the name space std.
> For me it's cleaner to make:
> #include <typeinfo>
> using namespace std;
> which will found a type_info at both place.
> namespace.diff was the forgotten patch.

Ok, we could #include <typeinfo>, but we shouldn't be using a 'using' 
directive in a header file, because that forces that directive to everyone 
using that header file. 'using' directives should only ever be in 
implementation files. Eek, 'using namespace Uml' is in there as well.

Regarding the other patch: why inherit virtually from QWidget? We don't have 
multiple inheritance anymore.

I committed the 'using namespace std;' patch for widgetfactory.cpp

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPmdPHKWgYMJuwmZtAQFKjggAqwWnZenEJQolIMLeS/+S63z9DKbmvVRb
TkGIXKs7E1QXWXM8sqblSw6KlKj3O2meeaLQQEEosT4TeQo4cF4EBw+YxFWm8Bmd
S8OpVFlXA4uZKb58NBLDkUJrhTJXiNmcZv4HvzyNcWLCWZPlc3GOf4lzonEuEaQN
o1DnqbkJk5/yRLVAT7HG4jIjkQnsqD4J85wc7TU1dkKbEP/6gyAsTMq37VwjjqVB
guFeth0aXjaAC6kCaaN5NTuBofRgW/HJIjjaAyCHyurg1esSzKnvHTOKr1CW12jT
8txs+AzIyoKk79Ic48NDugOgL8NEd/6FdQuXrfJsJPRR8a+zHSRF1w==
=uC1X
-----END PGP SIGNATURE-----