[Uml-devel] kdesdk/umbrello/umbrello

[Jonathan Riddell]

On Mon, Jul 07, 2003 at 07:57:32PM +0200, David Faure wrote:
> CVS commit by faure: 
> 
> Fix null-pointer-deref crash (I'm not sure why Jesper's document has an
> association with an A or B widget being 0 though)
> 
> 
>   M +4 -7      umlview.cpp   1.61
> 
> 
> --- kdesdk/umbrello/umbrello/umlview.cpp  #1.60:1.61
> @@ -2094,11 +2094,8 @@ void UMLView::selectAssociations(bool bS
>          while((assocwidget=assoc_it.current())) {
>                  ++assoc_it;
> -                if(bSelect) {
> -                        if(assocwidget->getWidgetA()->getSelected() &&
> -                           assocwidget->getWidgetB()->getSelected()) {
> +                if(bSelect &&
> +                  assocwidget->getWidgetA() && assocwidget->getWidgetA()->getSelected() &&
> +                  assocwidget->getWidgetB() && assocwidget->getWidgetB()->getSelected() ) {
>                                  assocwidget->setSelected(true);
> -                        } else {
> -                                assocwidget->setSelected(false);
> -                        }
>                  } else {
>                          assocwidget->setSelected(false);

Thanks for looking at the code.

This doesn't seem to have fixed Jespers bug 60685
http://bugs.kde.org/show_bug.cgi?id=60685

if that was what it was supposed to do.

Jonathan Riddell