[Uml-devel] CVSROOT (fwd)

[Jonathan Riddell]

Ah, you can tell a seasoned coder by the quality of their commit messages.

Also interesting to note is that Quanta have used Umbrello CVS version to
make diagrams of their programme, quanta_uml.xmi.

Jonathan Riddell

---------- Forwarded message ----------
Date: Tue,  4 Feb 2003 03:08:22 +0100 (CET)
From: Dirk Mueller <mueller at kde.org>
Reply-To: kde-cvs at kde.org
To: kde-cvs at kde.org
Subject: CVSROOT
Resent-Date: Tue, 4 Feb 2003 02:10:33 GMT
Resent-Date: Tue, 04 Feb 2003 02:10:34 +0000
Resent-From: kde-cvs at mail.kde.org

CVS commit by mueller:

the umbrello guys want our cool commit logs and not the sucking syncmail ones :)


  M +20 -10    loginfo.pl   1.106


--- CVSROOT/loginfo.pl  #1.105:1.106
@@ -18,4 +18,5 @@
 }

+$ccrecipients = "";
 $lastdir = "";
 $basedir = "";
@@ -29,4 +30,10 @@
 $srcfile = '\.(cpp|cc|cxx|C|c\+\+|c|l|y||h|H|hh|hxx|hpp|h\+\+)$';

+%directorysubscriptions = (
+  # key is a word matched against the commit-path,
+  # value is the recipient's address if the word matches
+  "umbrello" => "umbrello-devel\@kde.org"
+);
+
 sub read_state()
 {
@@ -168,4 +175,10 @@
 }

+sub add_to_cc($)
+{
+  my ($email) = @_;
+  $ccrecipients .= length($ccrecipients) ? ", $email" : "\nCc: $email" if($ccrecipients !~ /$email/);
+}
+
 # initialize with the default values
 $outText = "";
@@ -174,5 +187,4 @@
 $module = "";
 $recipient = "kde-cvs\@kde.org";
-$ccrecipients = "";
 $from = "";
 $tagname = "HEAD";
@@ -247,13 +259,5 @@
   }
   else {
-    if( /^CCMAIL:\s*(.*)\s*$/ ) {
-      my $email = $1;
-      if ( length($ccrecipients) ) {
-        $ccrecipients .= ", " . $email;
-      }
-      else {
-        $ccrecipients = "\nCc: ". $email;
-      }
-    }
+    &add_to_cc($1) if( /^CCMAIL:\s*(.*)\s*$/ );
   }

@@ -305,5 +309,11 @@
   $current = $1 if ($current =~ /^([^\/]+\/[^\/]+)\//);
   $dirs{$current} = 1;
+
+  # check if we want to cc somebody
+  foreach $key ( keys %directorysubscriptions ) {
+    &add_to_cc($directorysubscriptions{$key}) if ($current =~ /$key/);
+  }
 }
+
 my $commit_list = join(' ', (sort { $dirs{$b} <=> $dirs{$a} } keys %dirs));
 my $commit_dirs = "";