[Uml-devel] #include cleaning

[Sebastian Stein]

Jean Vittor <jean.vittor at wanadoo.fr> [021104 17:15]:
> Here attached some #include cleaning.
> ...

First of all thank you for your patch! Patches are very welcome!

But I have to tell you, that I won't commit the patched files to CVS because
of 1 reason:

- Umbrello doesn't compile with the patch applied:

source='ParsedSignalSlot.cc' object='ParsedSignalSlot.o' libtool=no \
depfile='.deps/ParsedSignalSlot.Po' tmpdepfile='.deps/ParsedSignalSlot.TPo'
\
depmode=gcc /bin/sh ../../admin/depcomp \
g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/opt/kde/include
-I/usr/lib/qt-3.0.3/include -I/usr/X11R6/include   -DQT_THREAD_SUPPORT
-D_REENTRANT  -O2 -fno-exceptions -fno-check-new  -c -o ParsedSignalSlot.o
`test -f 'ParsedSignalSlot.cc' || echo './'`ParsedSignalSlot.cc
In file included from ParsedSignalSlot.h:22,
                 from ParsedSignalSlot.cc:20:
ParsedMethod.h:30: parse error before `{'
ParsedMethod.h:34: destructors must be member functions
ParsedMethod.h:36: parse error before `public'
ParsedMethod.h:59: parse error before `public'
ParsedMethod.h:94: parse error before `public'
ParsedMethod.h:102: parse error before `public'
ParsedMethod.h:109: virtual outside class declaration
ParsedMethod.h:115: virtual outside class declaration
ParsedMethod.h:119: `method' was not declared in this scope
ParsedMethod.h:121: parse error before `}'
In file included from ParsedSignalSlot.cc:20:
ParsedSignalSlot.h:41: syntax error before `*'
ParsedSignalSlot.h:49: `aSlot' was not declared in this scope
ParsedSignalSlot.h:49: variable or field `setSlot' declared void
ParsedSignalSlot.cc:89: `aSlot' was not declared in this scope
ParsedSignalSlot.cc:90: `void CParsedSignalSlot::setSlot' is not a static
member of `class CParsedSignalSlot'
ParsedSignalSlot.cc:90: syntax error before `{'
ParsedSignalSlot.cc:91: ANSI C++ forbids declaration `kdWarning' with no
type
ParsedSignalSlot.cc: In function `int kdWarning()':
ParsedSignalSlot.cc:91: parse error before `<'
ParsedSignalSlot.cc:93: ANSI C++ forbids declaration `slot' with no type
ParsedSignalSlot.cc:93: confused by earlier errors, bailing out
make[3]: *** [ParsedSignalSlot.o] Fehler 1

So if you could fix it (and there are more compile errors in), we will be
glad to commit any patch removing unneeded code ;-)

Steinchen

PS: Please use diff -u (unified output format) for your next patch, it is
much easier to read by human.
-- 
Umbrello UML Modeller
Description     : UML diagram drawing tool for KDE with code generation
Homepage        : http://uml.sourceforge.net/
Bug report      : http://sourceforge.net/tracker/?group_id=24919&atid=382951
Feature request : http://sourceforge.net/tracker/?group_id=24919&atid=382954